Analyze descriptor methods as if they're methods, not functions #8365

janverb · 2020-02-04T16:45:25Z

When __get__ and __set__ were implicitly called they were analyzed without taking the type of the descriptor into account. That meant that they were only visible to plugins as function calls with unclear
names.

msullivan · 2020-02-10T19:18:27Z

This seems reasonable and I'm happy to merge it. Can a test be written, though?

janverb · 2020-02-10T22:21:36Z

Of course. Thank you for reminding me, I ended up finding an issue with how I did it.

When __get__ and __set__ were implicitly called they were analyzed without taking the type of the descriptor into account. That meant that they were only visible to plugins as function calls with unclear names.

janverb added 2 commits Feb 11, 2020

Analyze descriptor methods as if they're methods, not functions

88791a4

When __get__ and __set__ were implicitly called they were analyzed without taking the type of the descriptor into account. That meant that they were only visible to plugins as function calls with unclear names.

fixup! Analyze descriptor methods as if they're methods, not functions

facfd9b

janverb force-pushed the fix-descriptor-methods branch from dd4bab4 to facfd9b Compare Feb 11, 2020

msullivan merged commit 8b3b1d8 into python:master Feb 21, 2020

janverb deleted the fix-descriptor-methods branch Feb 24, 2020

Analyze descriptor methods as if they're methods, not functions #8365

Analyze descriptor methods as if they're methods, not functions #8365

janverb commented Feb 4, 2020

msullivan commented Feb 10, 2020

janverb commented Feb 10, 2020

Analyze descriptor methods as if they're methods, not functions #8365

Analyze descriptor methods as if they're methods, not functions #8365

Conversation

janverb commented Feb 4, 2020

msullivan commented Feb 10, 2020

janverb commented Feb 10, 2020