[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ mypy Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support determining whether a literal is truthy #8368

Merged
merged 1 commit into from Feb 7, 2020
Merged

Support determining whether a literal is truthy #8368

merged 1 commit into from Feb 7, 2020

Conversation

Copy link
Contributor

janverb commented Feb 5, 2020

This means types like Union[Literal[False], str] can be narrowed down more easily.

One test had to be adjusted, because it started checking more aggressively whether a union could be simplified. I think that's ok, because it's doing the equivalent of simplifying Union[Literal["foo"], str] to str, which seems correct.

Support determining whether a literal is truthy
92e0d28 
This means types like Union[Literal[False], str] can be narrowed down
more easily.
msullivan approved these changes Feb 7, 2020
View changes
Copy link
Collaborator

msullivan left a comment

Nice improvement!

msullivan merged commit d6c2c01 into python:master Feb 7, 2020
janverb deleted the literal-truthiness branch Feb 10, 2020
Michael0x2a mentioned this pull request Feb 10, 2020
Closed
This was referenced May 14, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

msullivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants