[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ mypy Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mypy.api.run_dmypy actually capture the output #8375

Merged
merged 1 commit into from Feb 6, 2020
Merged

Make mypy.api.run_dmypy actually capture the output #8375

merged 1 commit into from Feb 6, 2020

Conversation

Copy link
Collaborator

msullivan commented Feb 5, 2020

When the main run API was made threadsafe this broke output capturing
from run_dmypy. I don't really care about the threadsafety of
run_dmypy but I do care about output capture ever working, so I am
restoring the old sys.stdout swapping behavior for run_dmypy. I'd take
a patch to thread stdout through the client if anybody really cares.

Make mypy.api.run_dmypy actually capture the output
ddefb2a 
When the main run API was made threadsafe this broke output capturing
from run_dmypy. I don't really care about the threadsafety of
run_dmypy but I do care about output capture ever working, so I am
restoring the old sys.stdout swapping behavior for run_dmypy. I'd take
a patch to thread stdout through the client if anybody really cares.
ilevkivskyi approved these changes Feb 5, 2020
View changes
Copy link
Member

ilevkivskyi left a comment

Is the idea to silence/filter some output in wrapper scripts (e.g. suppress Daemon up and running for status check)? If yes, then I am all in favor.

Copy link
Collaborator Author

msullivan commented Feb 5, 2020

Yeah. When I went to do that, I discovered that our wrapper scripts were already trying to silence those messages, it just didn't work.

msullivan merged commit 0c03690 into master Feb 6, 2020
msullivan deleted the dmypy-api branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

ilevkivskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants