GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up|
Since EVP is now a heap allocated type, you should now properly refcount the type as well. You can read the details in: https://docs.python.org/3.8/whatsnew/3.8.html#changes-in-the-c-api, search for bpo-35810 Anyways, the TL;DR is that EVP_dealloc should now be:
|
Thanks! I missed the note. :) |
|
Perfect! This LGTM now! |
|
Agh I forget I don't have the commit bit here. Let's ping someone else to merge, cc @ericsnowcurrently @DinoV |
Signed-off-by: Christian Heimes <christian@python.org>
The updated type no longer accepts random arguments to __init__. Signed-off-by: Christian Heimes <christian@python.org>
Signed-off-by: Christian Heimes <christian@python.org>
Signed-off-by: Christian Heimes <christian@python.org>
|
@tiran: Please replace |
…H-16248) As mentioned in the bpo ticket, this mistake came up on two reviews: - #16127 (review) - #16071 (review) Would be nice to have it documented in a more permanent place than 3.8's whatsnew entry. https://bugs.python.org/issue38206 Automerge-Triggered-By: @encukou
tiran commentedSep 12, 2019
•
edited by ericsnowcurrently
The _hashlib OpenSSL wrapper extension module is now PEP 384 compliant.
Also remove refleak test from test_hashlib. The updated type no longer accepts random arguments to
__init__.https://bugs.python.org/issue38142