[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35766: Whats new in the ast and typing modules #13984

Merged
merged 2 commits into from Jun 11, 2019

Conversation

Reviewers

vstinner

ilevkivskyi

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
6 participants
Copy link
Member

commented Jun 11, 2019 •
edited by bedevere-bot

Lumping these together because they both come from the static type checking world.

https://bugs.python.org/issue35766

gvanrossum requested a review from ilevkivskyi Jun 11, 2019

the-knights-who-say-ni added the CLA signed label Jun 11, 2019

bedevere-bot added type-documentation awaiting core review labels Jun 11, 2019

gvanrossum added needs backport to 3.8 skip news labels Jun 11, 2019

gvanrossum requested a review from vstinner Jun 11, 2019

vstinner approved these changes Jun 11, 2019
View changes

Copy link
Member

left a comment

LGTM.

I looked for "3.8" in https://docs.python.org/dev/library/ast.html and https://docs.python.org/dev/library/typing.html and it seems like all changes are documented.

bedevere-bot added awaiting merge and removed awaiting core review labels Jun 11, 2019

ilevkivskyi approved these changes Jun 11, 2019
View changes

Copy link
Contributor

left a comment

Looks great!

gvanrossum merged commit 9b33ce4 into python:master Jun 11, 2019
5 checks passed

5 checks passed

Azure Pipelines PR #20190611.63 succeeded
Details
bedevere/issue-number Issue number 35766 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

This comment has been minimized.

Sign in to view
Copy link

commented Jun 11, 2019

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

This comment has been minimized.

Sign in to view
Copy link

commented Jun 11, 2019

Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label Jun 11, 2019

gvanrossum deleted the gvanrossum:whats-new-ast-typing branch Jun 11, 2019

This comment has been minimized.

Sign in to view
Copy link

commented Jun 11, 2019

GH-13987 is a backport of this pull request to the 3.8 branch.

bedevere-bot removed the needs backport to 3.8 label Jun 11, 2019

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 11, 2019

bpo-35766: What's new in the ast and typing modules (pythonGH-13984) 
(cherry picked from commit 9b33ce4)

Co-authored-by: Guido van Rossum <guido@python.org>
d73af3f

miss-islington added a commit that referenced this pull request Jun 11, 2019

bpo-35766: What's new in the ast and typing modules (GH-13984) 
(cherry picked from commit 9b33ce4)

Co-authored-by: Guido van Rossum <guido@python.org>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7856888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment