[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30688: Import unicodedata only when needed #5606

Merged
merged 1 commit into from Feb 10, 2018
Merged

bpo-30688: Import unicodedata only when needed #5606

merged 1 commit into from Feb 10, 2018

Conversation

Copy link
Contributor

fangyi-zhou commented Feb 10, 2018 •
edited by bedevere-bot

Importing unicodedata in this module leads to failure in compilation.
unicodedata is unused during compilation, and is not compiled when this
file is imported. The error occurs when generating posix variables,
pprint is required. The dependency chain goes on like this:

sysconfig -> pprint -> re -> sre_compile -> sre_parse (this file)

This commits fixes compilation issues introduced by
2272cec.
(Issue 30688, PR #5588)

https://bugs.python.org/issue30688

sre_parse: Import unicodedata only when needed
def110b 
Importing unicodedata in this module leads to failure in compilation.
unicodedata is unused during compilation, and is not compiled when this
file is imported. The error occurs when generating posix variables,
pprint is required. The dependency chain goes on like this:

sysconfig -> pprint -> re -> sre_compile -> sre_parse (this file)

This commits fixes compilation issues introduced by
2272cec.
(Issue 30688, PR #5588)
Copy link

the-knights-who-say-ni commented Feb 10, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

fangyi-zhou changed the title sre_parse: Import unicodedata only when needed bpo-30688: Import unicodedata only when needed Feb 10, 2018
serhiy-storchaka added type-bug skip news labels Feb 10, 2018
serhiy-storchaka merged commit 5df5286 into python:master Feb 10, 2018
4 checks passed
thetorpedodog pushed a commit to thetorpedodog/cpython that referenced this issue May 28, 2021
bpo-30688: Import unicodedata only when needed. (pythonGH-5606)
f8e50c2 
Importing unicodedata in sre_parse leads to failure in compilation.
unicodedata is unused during compilation, and is not compiled when this
file is imported. The error occurs when generating posix variables,
pprint is required. The dependency chain goes on like this:

sysconfig -> pprint -> re -> sre_compile -> sre_parse (this file)

This commits fixes compilation issues introduced by
2272cec.
(Issue 30688, pythonGH-5588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

serhiy-storchaka

Assignees
No one assigned
Labels
CLA signed skip news type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants