[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36623: Clean parser headers and include files #12253

Merged
merged 2 commits into from Apr 13, 2019
Merged

bpo-36623: Clean parser headers and include files #12253

merged 2 commits into from Apr 13, 2019

Conversation

Copy link
Member

pablogsal commented Mar 9, 2019 •
edited by bedevere-bot

All of these functions are not used/defined anymore.

https://bugs.python.org/issue36623

pablogsal force-pushed the clean_pgen branch 2 times, most recently from 32872e8 to 1b0478b Compare Mar 9, 2019
pablogsal requested a review from a team as a code owner Mar 9, 2019
pablogsal self-assigned this Mar 9, 2019
pablogsal requested a review from vstinner Mar 18, 2019
Copy link
Member

vstinner commented Mar 21, 2019

Sorry, I don't have bandwidth right now to review your PR. Maybe come back to me in 2 weeks. Your PR is scary because it's very long and it changes a lot of public headers at once.

Copy link
Member

zooba commented Apr 12, 2019

I think this should have a NEWS entry and What's New section, as it's removing headers that were publicly available (even if they should not have been).

On the off chance that it breaks somebody, that will give them an issue to come and post on, or at least read the rationale. It can be the same issue as the original change.

pablogsal changed the title Clean parser headers and include files bpo-36623: Clean parser headers and include files Apr 13, 2019
Copy link
Member

methane commented Apr 13, 2019

It seems simple removal. LGTM if CI can compile them without any warnings.

Copy link
Member Author

pablogsal commented Apr 13, 2019 •
edited

Resolved merge conflicts regarding the WhatsNew entry.

pablogsal merged commit f2cf1e3 into python:master Apr 13, 2019
5 checks passed
pablogsal deleted the clean_pgen branch Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

methane

windows-team

vstinner

Assignees

pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants