[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30993: IDLE - Improve configdialog font page and tests. #2818

Merged
merged 3 commits into from Jul 23, 2017
Merged

bpo-30993: IDLE - Improve configdialog font page and tests. #2818

merged 3 commits into from Jul 23, 2017

Conversation

Copy link
Member

terryjreedy commented Jul 22, 2017 •
edited by bedevere-bot

Copy link

mention-bot commented Jul 22, 2017

@terryjreedy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @csabella, @kbkaiser and @zooba to be potential reviewers.

Copy link
Member Author

terryjreedy commented Jul 22, 2017

screwed up, will try again

terryjreedy reopened this Jul 22, 2017
IDLE - Improve configdialog font page and tests.
00cdeff 
* Document causal pathways in docstring.
* Simplify some attribute names.
* Rename test_bold_toggle_set_samples to make test_font_set fail.
* Fix test_font_set so not order dependent.
* Fix renamed test_indent_scale so it tests the widget.
terryjreedy reopened this Jul 22, 2017
terryjreedy changed the title Fontchange bpo-30993: IDLE - Improve configdialog font page and tests. Jul 22, 2017
csabella reviewed Jul 22, 2017
View changes
Lib/idlelib/idle_test/test_configdialog.py
d = dialog
d.font_name.set('Test Font')
d.font_size.set(default_size)
d.font_bold.set(default_bold)
Copy link
Contributor

csabella Jul 22, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering - if you add a similar test as bold_toggle for the sizelist selection, maybe the initialization of the 3 Tk variables should be in setUp()? That would mean that all the tests start with the same values (presumably from GetFont), but the bold_toggle test is a lot different than that now. font_size 5 in that test isn't even on the menu for size, so it would be an invalid value there.

terryjreedy self-assigned this Jul 23, 2017
terryjreedy merged commit 07ba305 into python:master Jul 23, 2017
terryjreedy deleted the fontchange branch Jul 23, 2017
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jul 23, 2017
[3.6] bpo-30993: IDLE - Improve configdialog font page and tests. (py…
6acdda1 
…thonGH-2818)

* Document causal event pathways in docstring.
* Simplify some attribute names.
* Rename test_bold_toggle_set_samples to make test_font_set fail.
* Fix test_font_set so not order dependent.
* Fix renamed test_indent_scale so it tests the widget.
(cherry picked from commit 07ba305)
terryjreedy added a commit that referenced this pull request Jul 23, 2017
[3.6] bpo-30993: IDLE - Improve configdialog font page and tests. (GH…
5aa3bf0 
…-2818) (#2826)

* Document causal event pathways in docstring.
* Simplify some attribute names.
* Rename test_bold_toggle_set_samples to make test_font_set fail.
* Fix test_font_set so not order dependent.
* Fix renamed test_indent_scale so it tests the widget.
(cherry picked from commit 07ba305)
terryjreedy restored the fontchange branch Jul 23, 2017
terryjreedy deleted the fontchange branch Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

csabella

Assignees

terryjreedy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants