[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-25430: improve performance of IPNetwork.__contains__ #1785

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Copy link
Contributor

gescheit commented May 24, 2017

make a compare in bit-operation manner
see http://bugs.python.org/issue25430 for detail

https://bugs.python.org/issue25430

make a compare in bit-operation manner
Copy link

the-knights-who-say-ni commented May 24, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

Copy link

mention-bot commented May 24, 2017

@gescheit, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @serhiy-storchaka and @hynek to be potential reviewers.

Copy link
Member

pitrou commented May 24, 2017

Changed the CLA label as @gescheit is recorded as having signed it in Roundup: https://bugs.python.org/user15300

pitrou requested a review from serhiy-storchaka May 24, 2017
pitrou changed the title bpo-25430: performance improvements bpo-25430: improve performance of IPNetwork.__contains__ May 25, 2017
serhiy-storchaka added the performance Performance or resource usage label Dec 8, 2018
Copy link
Sponsor Contributor

BoboTiG commented Dec 11, 2018

Thanks @gescheit, changes looks good to me!
I think adding a NEWs entry would be good too, don't you?

Copy link
Contributor

asvetlov commented Dec 11, 2018

What is performance boost?

Copy link
Sponsor Contributor

BoboTiG commented Dec 12, 2018

@asvetlov you can find numbers in the description of the BPO.

Copy link
Contributor

asvetlov commented Dec 12, 2018

Got you. Thanks.
Could you please add a NEWS entry?
https://devguide.python.org/committing/?highlight=blurb#what-s-new-and-news-entries

asvetlov previously requested changes Dec 15, 2018
Copy link
Contributor

asvetlov left a comment

NEWS entry is requered

Copy link

bedevere-bot commented Dec 15, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Member

tirkarthi commented Apr 15, 2019

Ping @gescheit . This seems to be blocking only on NEWS entry. Can you please add one? It would be nice to see this as part of next release. You can add it from the web interface using https://blurb-it.herokuapp.com/ or using the blurb tool at https://pypi.org/project/blurb/

Thanks

methane merged commit 3bbcc92 into python:master Apr 30, 2019
Cant2 approved these changes Dec 4, 2022
Copy link

Cant2 left a comment


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review performance Performance or resource usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet