[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32999: Convert useless check to assert #6197

Merged
merged 1 commit into from Mar 23, 2018
Merged

bpo-32999: Convert useless check to assert #6197

merged 1 commit into from Mar 23, 2018

Conversation

Copy link
Member

methane commented Mar 23, 2018 •
edited by bedevere-bot

ilevkivskyi approved these changes Mar 23, 2018
View changes
Copy link
Member

ilevkivskyi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch!

methane merged commit c65bf3f into python:master Mar 23, 2018
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

methane deleted the bpo32999-assert branch March 23, 2018 09:19
Copy link

GH-6198 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2018
bpo-32999: ast: Convert useless check to assert (pythonGH-6197)
88711d0 
(cherry picked from commit c65bf3f)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 23, 2018
bpo-32999: ast: Convert useless check to assert (GH-6197)
c71edab 
(cherry picked from commit c65bf3f)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
bpo-32999: ast: Convert useless check to assert (pythonGH-6197)
8067e6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants