[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36333: Fix leak in _PyRuntimeState_Fini #12400

Merged
merged 1 commit into from Mar 19, 2019
Merged

bpo-36333: Fix leak in _PyRuntimeState_Fini #12400

merged 1 commit into from Mar 19, 2019

Conversation

Copy link
Member

matrixise commented Mar 18, 2019 •
edited by bedevere-bot

matrixise mentioned this pull request Mar 18, 2019
Closed
vstinner approved these changes Mar 18, 2019
View changes
Copy link
Member

vstinner left a comment

LGTM, but I would prefer that @ericsnowcurrently review it since he added _PyRuntime.xidregistry (and its mutex).

Copy link
Member

vstinner commented Mar 18, 2019

Python 3.7 is not affected: it doesn't have _PyRuntime.xidregistry.

eamanu approved these changes Mar 18, 2019
View changes
Copy link
Contributor

eamanu left a comment

LGTM!

vstinner requested a review from ericsnowcurrently Mar 18, 2019
ericsnowcurrently approved these changes Mar 18, 2019
View changes
Copy link
Member

ericsnowcurrently left a comment

LGTM

Thanks for working on this!

Copy link
Member

ericsnowcurrently commented Mar 18, 2019

FWIW, _PyRuntime.ceval.pending.lock may be leaking too.

Copy link
Member

vstinner commented Mar 18, 2019

FWIW, _PyRuntime.ceval.pending.lock may be leaking too.

@matrixise: Can you try to free _PyRuntime.ceval.pending.lock in _PyEval_FiniThreads()?

Copy link
Member Author

matrixise commented Mar 18, 2019

@ericsnowcurrently I will check in an other PR. Thanks for the review

Copy link
Member Author

matrixise commented Mar 18, 2019

Ok i will do it

vstinner merged commit 943395f into python:master Mar 19, 2019
Copy link
Member

vstinner commented Mar 19, 2019

I merged this PR, thanks @matrixise.

Oh, there are now too many leaks... I merged https://bugs.python.org/issue36356 PR and I wrote PR #12432 to free the pending lock, to have a better view of remaining leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

vstinner

ericsnowcurrently

eamanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants