Corresponding PR on pypy: https://bitbucket.org/pypy/pypy/pull-requests/655

@1st1

Can you double check if regular generators have the same behavior before we merge?

Well, I don't think this behavior applies to regular generators. The closest thing I could think of is:

>>> def gen():
...     try:
...         yield
...     finally:
...         yield
... 
>>> g = gen()
>>> g.send(None)
>>> g.close()

which produces:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: generator ignored GeneratorExit

Also note that the chunk of code added to async_gen_athrow_throw is directly taken from async_gen_athrow_send. A bit of refactoring might be required, although I don't feel comfortable enough to do it myself. A similar refactoring has been done in pypy: see the handle_error method which is used by both the send and throw methods of the athrow coroutine.

Just pinging, as it turns out to be a blocking issue for the aiostream library :)

Andrew, can you take a look at this too?

Is it urgent?
I'll have time next week only after finishing my business trip.

I guess since we missed the RC1 for this it's no longer urgent. But please look at this as soon as you can. I'd like to hear your opinion.

Hi all, I'm just pinging again as I would really like to have this issue fixed :)

LGTM

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

Thanks @vxgmichel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

GH-17257 is a backport of this pull request to the 3.7 branch.

Thanks @vxgmichel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

GH-17258 is a backport of this pull request to the 3.8 branch.

Thanks!