[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38588: Optimize list comparison. #17766

Merged
merged 1 commit into from Dec 31, 2019
Merged

bpo-38588: Optimize list comparison. #17766

merged 1 commit into from Dec 31, 2019
+3 −0

Conversation

Copy link
Member

methane commented Dec 31, 2019 •
edited by bedevere-bot

Mitigate performance regression of the list comparison caused by
2d5bf56.

https://bugs.python.org/issue38588
bpo-38588: Optimize list comparison.
Loading status checks…
84722af 
Mitigate performance regression of the list comparison caused by
2d5bf56.
methane added the skip news label Dec 31, 2019
methane requested review from corona10 and pablogsal Dec 31, 2019

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Dec 31, 2019 •
edited

Wouldn't this affect this case? [float("nan")] == [float("nan")]

Edit: Sorry, I checked and it should not affect it.
pablogsal approved these changes Dec 31, 2019
View changes
Copy link
Member

pablogsal left a comment

LGTM

Thanks for the analysis and the quick fix Inada-san.

And apologies for missing the comment in bpo.
corona10 approved these changes Dec 31, 2019
View changes
Copy link
Member

corona10 left a comment

LGTM

Thanks for the analysis @methane
methane merged commit dfef986 into python:master Dec 31, 2019
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20191231.4 succeeded
Details
bedevere/issue-number Issue number 38588 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
methane deleted the methane:list-cmp-opt branch Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

corona10

pablogsal

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants