[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-28167: bump Deprecated function removal to 3.8 #6669

Merged
merged 2 commits into from May 15, 2018
Merged

bpo-28167: bump Deprecated function removal to 3.8 #6669

merged 2 commits into from May 15, 2018

Conversation

Copy link
Contributor

Carreau commented May 1, 2018 •
edited by bedevere-bot

Also bump PendingDeprecationWarning to DeprecationWarning.

I'm guessing we are far enough in the cycle that it's too late for removal...

https://bugs.python.org/issue28167

bpo-28167 bump Deprecated function removal to 3.8
8190af2 
Also bump PendingDeprecationWarning to DeprecationWarning.
Copy link
Contributor Author

Carreau commented May 1, 2018

Not sure if requires a News item. If so can a skip-news label be added ?

Copy link
Contributor Author

Carreau commented May 1, 2018

Hum, looking at https://bugs.python.org/issue26041 from 2 years ago, it might also be possible to just delete the mention of removal in a future version.

vstinner approved these changes May 2, 2018
View changes
Copy link
Member

vstinner left a comment

LGTM.

Thanks for the link to the distro package!

Copy link
Member

vstinner commented May 2, 2018

Not sure if requires a News item. If so can a skip-news label be added ?

Please add a News entry. It's always a good idea to document deprecated features :-)

IMHO it would also help to document in What's New in Python 3.7 that platform.linux_distribution() is deprecated and will be removed from Python 3.8.

Copy link
Contributor Author

Carreau commented May 2, 2018

IMHO it would also help to document in What's New in Python 3.7 that platform.linux_distribution() is deprecated and will be removed from Python 3.8.

Done:

> cat Misc/NEWS.d/next/Library/2018-05-02-07-26-29.bpo-28167.7FwDfN.rst
The function ``platform.linux_ditribution`` and ``platform.dist`` now
trigger a ``DeprecationWarning`` and have been marked for removal in Python
3.8

The deprecation was already announced in 3.5 NEWS:

The platform.dist() and platform.linux_distribution() functions are now deprecated. Linux distributions use too many different ways of describing themselves, so the functionality is left to a package. (Contributed by Vajrasky Kok and Berker Peksag in bpo-1322.)

encukou merged commit 9eb40bc into python:master May 15, 2018
Copy link
Contributor

miss-islington commented May 15, 2018

Thanks @Carreau for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2018
bpo-28167: bump platform.linux_distribution removal to 3.8 (pythonGH-…
85d194d 
…6669)

Also bump PendingDeprecationWarning to DeprecationWarning.
(cherry picked from commit 9eb40bc)

Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
Copy link

bedevere-bot commented May 15, 2018

GH-6862 is a backport of this pull request to the 3.7 branch.

encukou pushed a commit that referenced this pull request May 15, 2018
bpo-28167: bump platform.linux_distribution removal to 3.8 (GH-6669) (G…
f4fdb61 
…H-6862)

Also bump PendingDeprecationWarning to DeprecationWarning.
(cherry picked from commit 9eb40bc)

Co-authored-by: Matthias Bussonnier <bussonniermatthias@gmail.com>
Copy link
Contributor Author

Carreau commented May 16, 2018

Thanks !

Carreau deleted the bump-deprecation branch May 16, 2018
encukou added a commit to encukou/distro that referenced this pull request May 16, 2018
Distro is the recommended replacement for platform.linux_distribution
8dd9ada 
The distro package is now recommended in Python documentation
as a replacement for `platform.linux_distribution`. See:

* https://docs.python.org/3.7/library/platform.html#platform.linux_distribution
* python/cpython#6669

Also, `platform.linux_distribution` is removed from
Python 3.8 (which is not released yet). See:

* https://docs.python.org/3.8/library/platform.html
* python/cpython#6871

Reflect this in `distro`'s README and docstring.
encukou mentioned this pull request May 16, 2018
Merged
nir0s pushed a commit to python-distro/distro that referenced this pull request May 17, 2018
Distro is the recommended replacement for platform.linux_distribution
500d206 
The distro package is now recommended in Python documentation
as a replacement for `platform.linux_distribution`. See:

* https://docs.python.org/3.7/library/platform.html#platform.linux_distribution
* python/cpython#6669

Also, `platform.linux_distribution` is removed from
Python 3.8 (which is not released yet). See:

* https://docs.python.org/3.8/library/platform.html
* python/cpython#6871

Reflect this in `distro`'s README and docstring.
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
bpo-28167: bump platform.linux_distribution removal to 3.8 (pythonGH-…
89f2e4d 
…6669)

Also bump PendingDeprecationWarning to DeprecationWarning.
nir0s pushed a commit to python-distro/distro that referenced this pull request Feb 2, 2019
Distro is the recommended replacement for platform.linux_distribution
3175628 
The distro package is now recommended in Python documentation
as a replacement for `platform.linux_distribution`. See:

* https://docs.python.org/3.7/library/platform.html#platform.linux_distribution
* python/cpython#6669

Also, `platform.linux_distribution` is removed from
Python 3.8 (which is not released yet). See:

* https://docs.python.org/3.8/library/platform.html
* python/cpython#6871

Reflect this in `distro`'s README and docstring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants