[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

Conversation

Copy link
Contributor

erlend-aasland commented May 29, 2020

Copy link
Member

ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS installer changes look fine, though I won't take the time to actually test them right now. Thanks, @erlend-aasland!

@zooba, What are your thoughts on backports? In principle, I'm fine with 3.9, 3.8, and 3.7.

Copy link
Contributor Author

@ned-deily, @zooba: SQLite 3.32.2 was released a couple of days ago. I've created a PR for cpython-source-deps. When that one goes through (and gets tagged), do you want me to update this PR, or is it cleaner to close this and create a new PR?

Copy link
Member

@erlend-aasland, Thanks for the 3.32.2 heads-up. I think either updating or a new pr is fine. Be aware, though, that I am pushing the macOS installer update in a separate PR as I'd like this to be in 390b2. So when you update this PR, please remove the Mac installer blurb entry; the build-installer change shouldn't conflict if you don't remove it :)

erlend-aasland changed the title bpo-40741: Update Windows and macOS installers to use SQLite 3.32.1 bpo-40741: Update Windows installer to use SQLite 3.32.1 Jun 8, 2020
Copy link
Contributor Author

Great that you got it in before 3.9-beta2, @ned-deily, thanks :) I've removed the macOS parts (both the blurb and the installer script) from this PR. Waiting for python/cpython-source-deps#20 to be merged and tagged.

erlend-aasland changed the title bpo-40741: Update Windows installer to use SQLite 3.32.1 bpo-40741: Update Windows installer to use SQLite 3.32.2 Jun 8, 2020
Copy link
Contributor Author

Thanks for merging python/cpython-source-deps#20, @zooba. I'll push a dummy commit just to kick off the CI on this PR, if you don't mind.

Copy link
Contributor Author

Closing this and reopening separate PR's for SQLite 3.32.3 for macOS and Windows.

erlend-aasland deleted the fix-issue-40741 branch June 19, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants