[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39453: Add testcase for bpo-39453 #18202

Merged
merged 2 commits into from Jan 27, 2020
Merged

bpo-39453: Add testcase for bpo-39453 #18202

merged 2 commits into from Jan 27, 2020
+3 −1

Conversation

Copy link
Member

corona10 commented Jan 27, 2020 •
edited by miss-islington

https://bugs.python.org/issue39453

Automerge-Triggered-By: @pablogsal

Automerge-Triggered-By: @pablogsal
bpo-39453: Add test
Loading status checks…
5169f9b
corona10 requested a review from pablogsal Jan 27, 2020

This comment has been minimized.

Sign in to view
Copy link
Member Author

corona10 commented Jan 27, 2020

@pablogsal I will include this PR into backporting patch for #18181 to 3.8 3.7. 3.6

This case should be added for 3.8, 3.7 and 3.6
corona10 added the skip news label Jan 27, 2020
pablogsal approved these changes Jan 27, 2020
View changes

This comment has been minimized.

Sign in to view
Copy link
Member

pablogsal commented Jan 27, 2020

Thanks @corona10 ! 🎉
bpo-39453: nit fix
Loading status checks…
6b05c49
corona10 force-pushed the corona10:bpo-39453-test branch from e753c01 to 6b05c49 Jan 27, 2020
corona10 requested a review from pablogsal Jan 27, 2020
pablogsal approved these changes Jan 27, 2020
View changes

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

@corona10: Status check is done, and it's a failure ❌ .
1 similar comment

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

@corona10: Status check is done, and it's a failure ❌ .

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Jan 27, 2020

@corona10: Status check is done, and it's a success ✅ .
miss-islington merged commit 9e1ed51 into python:master Jan 27, 2020
8 checks passed
8 checks passed
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200127.26 succeeded
Details
bedevere/issue-number Issue number 39453 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

pablogsal

Assignees
No one assigned
Labels
🤖 automerge CLA signed skip news type-tests
Projects
None yet
Milestone
No milestone
5 participants