[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.6] bpo-39453: Multiple backport patch for use after free with list and dict #18206

Closed
wants to merge 4 commits into from
Closed

[3.6] bpo-39453: Multiple backport patch for use after free with list and dict #18206

wants to merge 4 commits into from

Conversation

Copy link
Member

corona10 commented Jan 27, 2020 •
edited by bedevere-bot

ZackerySpytz and others added 4 commits Jan 27, 2020
bpo-38610: Fix possible crashes in several list methods (pythonGH-17022)
cf7cdaa 
Hold strong references to list elements while calling PyObject_RichCompareBool().
[3.7] bpo-38588: Fix possible crashes in dict and list when calling P… (
d5bf3e8 
pythonGH-17765)

* [3.7] bpo-38588: Fix possible crashes in dict and list when calling PyObject_RichCompareBool (pythonGH-17734)

Take strong references before calling PyObject_RichCompareBool to protect against the case
where the object dies during the call..
(cherry picked from commit 2d5bf56)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

* methane's suggestion

methane's suggestion

Co-Authored-By: Inada Naoki <songofacandy@gmail.com>

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
bpo-39453: Make list.__contains__ hold strong references to avoid cra…
9d3e26d 
…shes (pythonGH-18181)
bpo-39453: Add testcase for bpo-39453
3bf6d7b
corona10 requested a review from pablogsal Jan 27, 2020
Copy link
Member Author

corona10 commented Jan 27, 2020

@pablogsal Please take a look in care, this backport patch is including the missing backport patch for 3.6

corona10 changed the title bpo-39453: Multiple backport patch for use after free with list and dict [3.6] bpo-39453: Multiple backport patch for use after free with list and dict Jan 27, 2020
Copy link
Member

pablogsal commented Jan 27, 2020

Please, create two different PRs then. If we need to revert one of them we don't want to revert everything.

Copy link
Member Author

corona10 commented Jan 27, 2020

@pablogsal Got it, I close this PR :)

corona10 closed this Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

pablogsal

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants