Closes bpo-28292: Implemented Calendar.itermonthdays3() and itermonthdays4(). #4079

abalkin · 2017-10-23T03:33:59Z

Calendar.itermonthdates() will now consistently raise an exception when a date falls outside of the 0001-01-01 through 9999-12-31 range. To support applications that cannot tolerate such exceptions, the new methods itermonthdays3() and itermonthdays4() are added. The new methods return tuples and are not restricted by the range supported by datetime.date.

Thanks @serhiy-storchaka for suggesting the itermonthdays4() method and for the review.

https://bugs.python.org/issue28292

…days4().

serhiy-storchaka

LGTM, but needs a documentation.

serhiy-storchaka · 2017-10-23T21:25:46Z

Lib/calendar.py

@@ -180,6 +186,32 @@ def itermonthdays2(self, year, month):
        for i, d in enumerate(self.itermonthdays(year, month), self.firstweekday):
            yield d, i % 7

+    def itermonthdays3(self, year, month):


The order of methods: itermonthdays2, itermonthdays3, itermonthdays4, itermonthdays looks slightly inconsistent.

bedevere-bot added the awaiting merge label Oct 23, 2017

the-knights-who-say-ni added the CLA signed label Oct 23, 2017

abalkin requested a review from serhiy-storchaka Oct 23, 2017

Closes bpo-28292: Implemented Calendar.itermonthdays3() and itermonth…

cf3a675

…days4().

abalkin force-pushed the issue-28292 branch from 9272cde to cf3a675 Compare Oct 23, 2017

abalkin changed the title ~~Implemented Calendar.itermonthdays3() and itermonthdays4().~~ Closes bpo-28292: Implemented Calendar.itermonthdays3() and itermonthdays4(). Oct 23, 2017

abalkin self-assigned this Oct 23, 2017

serhiy-storchaka reviewed Oct 23, 2017

View changes

abalkin added 3 commits Oct 23, 2017

Documented the new calendar methods.

e794c06

Changed the order of Calendar method definitions.

3862fec

Added a NEWS entry.

b18ed1a

serhiy-storchaka approved these changes Oct 24, 2017

View changes

abalkin merged commit fdd9b21 into python:master Oct 24, 2017
3 checks passed

bedevere-bot removed the awaiting merge label Oct 24, 2017

abalkin deleted the issue-28292 branch Oct 24, 2017

python / cpython Public

Closes bpo-28292: Implemented Calendar.itermonthdays3() and itermonthdays4(). #4079

Closes bpo-28292: Implemented Calendar.itermonthdays3() and itermonthdays4(). #4079

abalkin commented Oct 23, 2017 •

edited

serhiy-storchaka left a comment

serhiy-storchaka Oct 23, 2017

python / cpython Public

Closes bpo-28292: Implemented Calendar.itermonthdays3() and itermonthdays4(). #4079

Closes bpo-28292: Implemented Calendar.itermonthdays3() and itermonthdays4(). #4079

Conversation

abalkin commented Oct 23, 2017 • edited

serhiy-storchaka left a comment

serhiy-storchaka Oct 23, 2017

Choose a reason for hiding this comment

abalkin commented Oct 23, 2017 •

edited