GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up|
Adding @taleinat as a reviewer |
|
I'm not very familiar with asyncio, but it seems to me that in these cases the code should raise an exception rather than emit a warning. A |
|
Agree with @taleinat, a |
|
Agree as well. |
Hi all, would fix it to throw a TypeError exception, I was following the thread in bpo - there was a discussion about sending a warning first instead of just throwing an exception without any notice first. Will commit a new version soon! |
|
Commited the new version: raising TypeError instead of a warning. |
|
@taleinat Maybe we can push this one as well? (been pending 2 months) |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry for letting this languish, that's definitely on me! Thanks for the reminder. For this, we'll also need to add a NEWS entry. You can use blurb-it to do so easily in the browser, or install locally with |
|
LGTM |
|
Sorry, I can't merge this PR. Reason: |
|
Sorry, I can't merge this PR. Reason: |
|
Sorry, I can't merge this PR. Reason: |
|
Thanks @idomic for the PR |
|
Sorry @idomic, I had trouble checking out the |
|
Sorry, I can't merge this PR. Reason: |
|
GH-17495 is a backport of this pull request to the 3.7 branch. |
…unctions (pythonGH-16457) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <michael.ido@gmail.com>
|
GH-17496 is a backport of this pull request to the 3.8 branch. |
…ncio functions (pythonGH-16457) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <michael.ido@gmail.com>
…ncio functions (GH-16457) (#17496) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <michael.ido@gmail.com>
…unctions (GH-16457) https://bugs.python.org/issue37404 (cherry picked from commit 892f9e0) Co-authored-by: idomic <michael.ido@gmail.com>
|
|
idomic commentedSep 28, 2019
•
edited by miss-islington
https://bugs.python.org/issue37404
Automerge-Triggered-By: @asvetlov