[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32411: IDLE: Remove line number sort in browser.py #5011

Merged
merged 3 commits into from Jun 1, 2019
Merged

bpo-32411: IDLE: Remove line number sort in browser.py #5011

merged 3 commits into from Jun 1, 2019

Conversation

Copy link
Contributor

csabella commented Dec 25, 2017 •
edited by bedevere-bot

Since the input dictionary is created in line number and dictionaries are guaranteed to be in insertion order, the sort is no longer needed.

https://bugs.python.org/issue32411

csabella requested a review from terryjreedy as a code owner Dec 25, 2017
csabella mentioned this pull request May 20, 2018
Closed
Copy link
Member

terryjreedy commented May 20, 2018

ON HOLD, as explained on the issue.

terryjreedy self-assigned this May 20, 2018
terryjreedy added performance Performance or resource usage needs backport to 3.7 labels May 20, 2018
terryjreedy requested changes May 20, 2018
View changes
Copy link
Member

terryjreedy left a comment

The requested 'change' is to wait for circumstances to change ;-).

python deleted a comment from bedevere-bot May 20, 2018
Copy link
Contributor

rhettinger commented Jun 1, 2019

LGTM.

terryjreedy changed the title bpo-32411: IDLE: Remove sorting by line number in browser.py bpo-32411: IDLE: Remove line number sort in browser.py Jun 1, 2019
terryjreedy merged commit 1a4d9ff into python:master Jun 1, 2019
Copy link

bedevere-bot commented Jun 1, 2019

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

Copy link
Contributor

miss-islington commented Jun 1, 2019

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2019
bpo-32411: IDLE: Remove line number sort in browser.py (pythonGH-5011)
82db303 
Insertion in line order makes sorting keys by line order unneeded.
(cherry picked from commit 1a4d9ff)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Copy link

bedevere-bot commented Jun 1, 2019

GH-13732 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jun 1, 2019
bpo-32411: IDLE: Remove line number sort in browser.py (GH-5011)
ac60d1a 
Insertion in line order makes sorting keys by line order unneeded.
(cherry picked from commit 1a4d9ff)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
csabella deleted the bpo32411 branch Jun 1, 2019
Copy link
Contributor Author

csabella commented Jun 1, 2019

@terryjreedy, thank you!

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
bpo-32411: IDLE: Remove line number sort in browser.py (python#5011)
1d86d56 
Insertion in line order makes sorting keys by line order unneeded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

terryjreedy

Assignees

terryjreedy

Labels
performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants