[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-19466: Py_Finalize() clears daemon threads earlier #18848

Merged
merged 1 commit into from
Mar 9, 2020
Merged

bpo-19466: Py_Finalize() clears daemon threads earlier #18848

merged 1 commit into from
Mar 9, 2020

Conversation

Copy link
Member

vstinner commented Mar 8, 2020 •
edited by bedevere-bot
Loading

Clear the frames of daemon threads earlier during the Python shutdown to
call objects destructors. So "unclosed file" resource warnings are now
emitted for daemon threads in a more reliable way.

Cleanup _PyThreadState_DeleteExcept() code: rename "garbage" to
"list".

https://bugs.python.org/issue19466

vstinner changed the title bpo-19466: Py_Finalize() clears daemon threads earlier [WIP] bpo-19466: Py_Finalize() clears daemon threads earlier Mar 8, 2020
Copy link
Member Author

vstinner commented Mar 8, 2020 •
edited by bedevere-bot
Loading

Oh, this change does not work as expected, it does introduce a crash, see:
https://bugs.python.org/issue19466#msg363654

It seems like the commit eb4e2ae (bpo-39877) introduced a race condition.

vstinner mentioned this pull request Mar 8, 2020
Closed
aeros reviewed Mar 9, 2020
View reviewed changes
Python/pylifecycle.c Outdated Show resolved Hide resolved
Copy link
Member Author

vstinner commented Mar 9, 2020 •
edited by bedevere-bot
Loading

Oh, this change does not work as expected, it does introduce a crash, see:
https://bugs.python.org/issue19466#msg363654
It seems like the commit eb4e2ae (bpo-39877) introduced a race condition.

I wrote PR #18854 to fix this bug.

bpo-19466: Py_Finalize() clears daemon threads earlier
0e5fd0b 
Clear the frames of daemon threads earlier during the Python shutdown to
call objects destructors. So "unclosed file" resource warnings are now
emitted for daemon threads in a more reliable way.

Cleanup _PyThreadState_DeleteExcept() code: rename "garbage" to
"list".
vstinner changed the title [WIP] bpo-19466: Py_Finalize() clears daemon threads earlier bpo-19466: Py_Finalize() clears daemon threads earlier Mar 9, 2020
vstinner merged commit 9ad58ac into python:master Mar 9, 2020
vstinner deleted the finalize_daemon_threads branch March 9, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

aeros aeros left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants