Closes bpo-28281: Remove year (1-9999) limits on the weekday() function. #4109

abalkin · 2017-10-24T17:35:06Z

A patch by Mark Gollahon.

https://bugs.python.org/issue28281

taleinat · 2017-10-26T05:57:02Z

For reference, this is awaiting documentation improvements, to be done either by the original author or by @abalkin.

Small reminder, @abalkin, to make sure the original author has signed a CLA.

serhiy-storchaka · 2017-10-26T07:46:00Z

Lib/calendar.py

@@ -111,8 +111,10 @@ def leapdays(y1, y2):


 def weekday(year, month, day):
-    """Return weekday (0-6 ~ Mon-Sun) for year (1970-...), month (1-12),
-       day (1-31)."""
+    """Return weekday (0-6 ~ Mon-Sun) for year (MINYEAR-MAXYEAR),


But this patch makes years out of range MINYEAR-MAXYEAR be supported.

abalkin · 2017-10-26T16:33:36Z

@taleinat - yes, according to the bpo, Mark Gollahon has signed a CLA.

the-knights-who-say-ni added the CLA signed label Oct 24, 2017

bedevere-bot added the awaiting merge label Oct 24, 2017

serhiy-storchaka reviewed Oct 26, 2017

View changes

Closes bpo-28281: Remove year (1-9999) limits on the weekday() function.

b9751cc

abalkin force-pushed the bpo-28281 branch from 39deb3c to b9751cc Compare Oct 26, 2017

abalkin added 2 commits Oct 26, 2017

Documentation.

986b496

Acknowlegements

4e6b07d

abalkin self-assigned this Oct 26, 2017

abalkin merged commit 66c88ce into python:master Oct 26, 2017
3 checks passed

bedevere-bot removed the awaiting merge label Oct 26, 2017

python / cpython Public

Closes bpo-28281: Remove year (1-9999) limits on the weekday() function. #4109

Closes bpo-28281: Remove year (1-9999) limits on the weekday() function. #4109

abalkin commented Oct 24, 2017 •

edited by bedevere-bot

taleinat commented Oct 26, 2017

serhiy-storchaka Oct 26, 2017

abalkin commented Oct 26, 2017

python / cpython Public

Closes bpo-28281: Remove year (1-9999) limits on the weekday() function. #4109

Closes bpo-28281: Remove year (1-9999) limits on the weekday() function. #4109

Conversation

abalkin commented Oct 24, 2017 • edited by bedevere-bot

taleinat commented Oct 26, 2017

serhiy-storchaka Oct 26, 2017

Choose a reason for hiding this comment

abalkin commented Oct 26, 2017

abalkin commented Oct 24, 2017 •

edited by bedevere-bot