[3.6] bpo-29692: contextlib.contextmanager may incorrectly unchain Ru… #1105

Mariatta · 2017-04-13T03:55:15Z

…ntimeError (GH-949)

contextlib._GeneratorContextManager.exit includes a special case to deal with
PEP 479 RuntimeErrors created when StopIteration is thrown into the context
manager body.

Previously this check was too permissive, and undid one level of chaining on all
RuntimeError instances, not just those that wrapped a StopIteration instance.
(cherry picked from commit 00c75e9)

…ntimeError (pythonGH-949) contextlib._GeneratorContextManager.__exit__ includes a special case to deal with PEP 479 RuntimeErrors created when `StopIteration` is thrown into the context manager body. Previously this check was too permissive, and undid one level of chaining on *all* RuntimeError instances, not just those that wrapped a StopIteration instance. (cherry picked from commit 00c75e9)

Mariatta added the cherry-pick for 3.6 label Apr 13, 2017

the-knights-who-say-ni added the CLA signed label Apr 13, 2017

Mariatta merged commit 9b409ff into python:3.6 Apr 13, 2017

Mariatta deleted the backport-00c75e9-3.6 branch Apr 13, 2017

[3.6] bpo-29692: contextlib.contextmanager may incorrectly unchain Ru… #1105

[3.6] bpo-29692: contextlib.contextmanager may incorrectly unchain Ru… #1105

Conversation

Mariatta commented Apr 13, 2017