[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-37428: Don't set PHA verify flag on client side (GH-14494) #14494

Merged
merged 1 commit into from Jul 1, 2019
Merged

[3.8] bpo-37428: Don't set PHA verify flag on client side (GH-14494) #14494

merged 1 commit into from Jul 1, 2019

Conversation

Copy link
Member

tiran commented Jul 1, 2019 •
edited by bedevere-bot

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)

https://bugs.python.org/issue37428

[3.8] bpo-37428: Don't set PHA verify flag on client side (pythonGH-1…
196f2b5 
…4421)

SSLContext.post_handshake_auth = True no longer sets
SSL_VERIFY_POST_HANDSHAKE verify flag for client connections. Although the
option is documented as ignored for clients, OpenSSL implicitly enables cert
chain validation when the flag is set.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue37428
(cherry picked from commit f0f5930)

Co-authored-by: Christian Heimes <christian@python.org>
bedevere-bot mentioned this pull request Jul 1, 2019
Merged
bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting core review labels Jul 1, 2019
tiran changed the title [3.8] bpo-37428: Don't set PHA verify flag on client side (GH-14421) [3.8] bpo-37428: Don't set PHA verify flag on client side (GH-14494) Jul 1, 2019
tiran merged commit f22c4cf into python:3.8 Jul 1, 2019
Copy link
Member Author

tiran commented Jul 1, 2019 •
edited by bedevere-bot

GH limits the title to 72 chars and didn't let me merge this PR with commit message [3.8] [bpo-37428](https://bugs.python.org/issue37428): Don't set PHA verify flag on client side (GH-14421) (GH-14493).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants