[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. #5284

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Copy link
Contributor

stratakis commented Jan 23, 2018

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.

https://bugs.python.org/issue32635

…rypt.

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.
Copy link
Member

vstinner left a comment

LGTM.

tiran approved these changes Jan 23, 2018
Copy link
Contributor

miss-islington commented Jan 24, 2018

Thanks @stratakis for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒🤖 I'm not a witch! I'm not a witch!

Copy link
Contributor

miss-islington commented Jan 24, 2018

Thanks @stratakis for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒🤖

Copy link

bedevere-bot commented Jan 24, 2018

GH-5295 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2018
…ypt. (pythonGH-5284)

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.
(cherry picked from commit e768c86)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2018
…ypt. (pythonGH-5284)

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.
(cherry picked from commit e768c86)
Copy link

bedevere-bot commented Jan 24, 2018

GH-5296 is a backport of this pull request to the 3.6 branch.

vstinner pushed a commit that referenced this pull request Jan 24, 2018
…ypt. (GH-5284) (#5295)

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.
(cherry picked from commit e768c86)
stratakis deleted the libxcrypt branch Jan 24, 2018
vstinner pushed a commit that referenced this pull request Jan 24, 2018
…ypt. (GH-5284) (#5296)

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.
(cherry picked from commit e768c86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants