[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (GH-5284) #5295

Merged
merged 1 commit into from Jan 24, 2018
Merged

[2.7] bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (GH-5284) #5295

merged 1 commit into from Jan 24, 2018

Conversation

Copy link
Contributor

miss-islington commented Jan 24, 2018 •
edited by bedevere-bot

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.
(cherry picked from commit e768c86)

https://bugs.python.org/issue32635

bpo-32635: Fix a segfault when importing the crypt module with libxcr…
61b978f 
…ypt. (pythonGH-5284)

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.
(cherry picked from commit e768c86)
bedevere-bot mentioned this pull request Jan 24, 2018
Merged
vstinner approved these changes Jan 24, 2018
View changes
Copy link
Member

vstinner left a comment

LGTM, good bot.

Copy link
Contributor Author

miss-islington commented Jan 24, 2018

@stratakis and @vstinner: Backport status check is done, and it's a success ✅ .

Copy link
Member

vstinner commented Jan 24, 2018

@tiran agrees that a 2.7 backport is needed: "yes, go ahead"
https://bugs.python.org/issue32635#msg310575

vstinner merged commit 6ccdad7 into python:2.7 Jan 24, 2018
Copy link
Contributor Author

miss-islington commented Jan 24, 2018

Thanks, @vstinner!

miss-islington deleted the backport-e768c86-2.7 branch Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants