[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence error output in test_concurrent_futures (bpo-21423) #4347

Merged
merged 3 commits into from Nov 9, 2017
Merged

Silence error output in test_concurrent_futures (bpo-21423) #4347

merged 3 commits into from Nov 9, 2017

Conversation

Copy link
Member

pitrou commented Nov 9, 2017 •
edited by bedevere-bot

serhiy-storchaka previously approved these changes Nov 9, 2017
View changes
Copy link
Member

serhiy-storchaka left a comment

Excellent! I'm not well known with logging, but it seems to me that this fixes the issue in right way.

Lib/test/test_concurrent_futures.py Outdated
while True:
try:
output.append(self.log_queue.get_nowait().getMessage())
except queue.Empty:
Copy link
Member

serhiy-storchaka Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could catch an exception outside of the loop.

Copy link
Member Author

pitrou Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right.

serhiy-storchaka dismissed their stale review Nov 9, 2017

But tests are failed on Windows. :(

serhiy-storchaka added the tests Tests in the Lib/test dir label Nov 9, 2017
Copy link
Member Author

pitrou commented Nov 9, 2017

I've fixed the tests on Windows now.

pitrou merged commit 0a2ff23 into python:master Nov 9, 2017
pitrou deleted the silence_cf_initializer_test branch Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

serhiy-storchaka

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants