[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39639: remove suite node #18513

Merged
merged 3 commits into from Mar 4, 2020
Merged

bpo-39639: remove suite node #18513

merged 3 commits into from Mar 4, 2020

Conversation

Copy link
Member

isidentical commented Feb 15, 2020

Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
Copy link

brettcannon commented Mar 3, 2020

I haven't touched the AST in a while, so it would be great if someone else can just double-check me. Otherwise, @isidentical , if no other review comes in by Friday just ping me and I will merge this.

Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
Copy link
Member

vstinner left a comment

I suggest to change the PR title to " bpo-39639: Remove ast.Suite node class". It can be done when the PR is merged.

Parser/Python.asdl Show resolved Hide resolved
Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
Co-Authored-By: Victor Stinner <vstinner@python.org>
isidentical requested a review from vstinner Mar 4, 2020
pablogsal merged commit d82e469 into python:master Mar 4, 2020
9 checks passed
Copy link

vstinner commented Mar 4, 2020

@isidentical: Thanks for the doc update, it's now well better ;-) Thanks also for clearing the old dust of from the early age of Python ;)

vegerot pushed a commit to vegerot/cpython that referenced this issue Jun 10, 2020
…18513)

The AST "Suite" node is no longer used and it can be removed from the ASDL definition and related structures (compiler, visitors, ...).

Co-Authored-By: Victor Stinner <vstinner@python.org>
Co-authored-by: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
vegerot pushed a commit to vegerot/cpython that referenced this issue Jun 10, 2020
…18513)

The AST "Suite" node is no longer used and it can be removed from the ASDL definition and related structures (compiler, visitors, ...).

Co-Authored-By: Victor Stinner <vstinner@python.org>
Co-authored-by: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
gmelikov pushed a commit to gmelikov/cpython that referenced this issue Aug 22, 2020
…18513)

The AST "Suite" node is no longer used and it can be removed from the ASDL definition and related structures (compiler, visitors, ...).

Co-Authored-By: Victor Stinner <vstinner@python.org>
Co-authored-by: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
chrisburr pushed a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
…18513)

The AST "Suite" node is no longer used and it can be removed from the ASDL definition and related structures (compiler, visitors, ...).

Co-Authored-By: Victor Stinner <vstinner@python.org>
Co-authored-by: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
colesbury pushed a commit to colesbury/nogil that referenced this issue Oct 6, 2021
…18513)

The AST "Suite" node is no longer used and it can be removed from the ASDL definition and related structures (compiler, visitors, ...).

Co-Authored-By: Victor Stinner <vstinner@python.org>
Co-authored-by: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants