[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30860: Move windows.h include out of internal/*.h. #3458

Merged
merged 3 commits into from
Sep 12, 2017
Merged

bpo-30860: Move windows.h include out of internal/*.h. #3458

merged 3 commits into from
Sep 12, 2017

Conversation

Copy link
Member

ericsnowcurrently commented Sep 8, 2017 •
edited by bedevere-bot
Loading

PR #3397 introduced a large number of warnings to the Windows build. This patch fixes them.

https://bugs.python.org/issue30860

ericsnowcurrently requested a review from a team September 8, 2017 17:37
Copy link
Member Author

I'm guessing that the following line in PCbuild/pyproject.props is causing the trouble:

<_PydPreprocessorDefinition Condition="$(TargetExt) == '.pyd'">Py_BUILD_CORE_MODULE;</_PydPreprocessorDefinition>

I'll try a related workaround and see if that resolves the current issue.

Copy link
Member Author

Yep, looks like that was it! \o/

ericsnowcurrently merged commit fc1bf87 into python:master Sep 12, 2017
ericsnowcurrently deleted the fix-windows-warnings branch September 12, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants