Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
|
Is it possible to test a failed Since this is a behavior breaking change, please add a note in What's New (section "Changes in the Python API"). |
It's possible to get
Done. |
|
Since we already do range checking in |
| @@ -265,6 +265,13 @@ Changes in the Python API | |||
| task name is visible in the ``repr()`` output of :class:`asyncio.Task` and | |||
| can also be retrieved using the :meth:`~asyncio.Task.get_name` method. | |||
|
|
|||
| * The :meth:`mmap.flush() <mmap.mmap.flush>` method now returns ``None`` on | |||
| success and raises an exception on error under all platforms. Previously, | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to accent the main reason of this change. "Previously, the behavior was platform-depended: on success, a nonzero value was returned under Windows and a zero value was returned under Unix, on error, zero was returned under Windows and an exception was raised under Unix." Maybe native speakers can suggest better wording. In any case this PR LGTM.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
You're right, I just tweaked it a bit.
Previously, its behavior was platform-dependent and there was no error checking under Windows.
https://bugs.python.org/issue2122