[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36465: Make release and debug ABI compatible #12615

Merged
merged 1 commit into from Apr 24, 2019

Conversation

Copy link
Member

vstinner commented Mar 28, 2019

Release build and debug build are now ABI compatible: the Py_DEBUG
define no longer implies Py_TRACE_REFS define which introduces the
only ABI incompatibility.

A new "./configure --with-trace-refs" build option is now required to
get Py_TRACE_REFS define which adds sys.getobjects() function and
PYTHONDUMPREFS environment variable.

Changes:

  • Add ./configure --with-trace-refs
  • Py_DEBUG no longer implies Py_TRACE_REFS

https://bugs.python.org/issue36465

Copy link
Member Author

vstinner commented Apr 9, 2019

I rebased my PR and I added a NEWS entry.

vstinner changed the title [WIP] bpo-36465: Py_DEBUG no longer implies Py_TRACE_REFS bpo-36465: Make release and debug ABI compatible Apr 24, 2019
vstinner force-pushed the disable_trace_refs branch 2 times, most recently from 0d8f77a to 00580bc Compare Apr 24, 2019
Copy link
Member Author

vstinner commented Apr 24, 2019

I reverted the following change:

* The "d" flag of SOABI (sys.implementation.cache_tag) is now
  only added by --with-trace-refs. It is no longer added by
  --with-pydebug.

I found an issue between libpython and SOABI: https://mail.python.org/pipermail/python-dev/2019-April/157186.html

I will work on a separated PR to remove "d" from SOABI, to handle properly the libpython issue.

This PR is not restricted to "Py_DEBUG no longer implies Py_TRACE_REFS".

Copy link
Member Author

vstinner commented Apr 24, 2019

@pitrou: You approved the idea on the python-dev, would you mind to approve the PR as well?
https://mail.python.org/pipermail/python-dev/2019-April/157185.html

@gvanrossum: Ditto. You approved the idea on the python-dev, would you mind to approve the PR as well?
https://mail.python.org/pipermail/python-dev/2019-April/157066.html

vstinner requested a review from gvanrossum Apr 24, 2019
Copy link
Member

gvanrossum left a comment

I'm sorry, I'm not the one who should review this. I have no relevant knowledge any more.

configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
Release build and debug build are now ABI compatible: the Py_DEBUG
define no longer implies Py_TRACE_REFS define which introduces the
only ABI incompatibility.

A new "./configure --with-trace-refs" build option is now required to
get Py_TRACE_REFS define which adds sys.getobjects() function and
PYTHONDUMPREFS environment variable.

Changes:

* Add ./configure --with-trace-refs
* Py_DEBUG no longer implies Py_TRACE_REFS
Copy link
Member Author

vstinner commented Apr 24, 2019

@pablogsal: Thanks, I fixed the 3 typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants