[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.Task.all_tasks() #20874

Merged
merged 4 commits into from Jul 2, 2020
Merged

bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.Task.all_tasks() #20874

merged 4 commits into from Jul 2, 2020

Conversation

Copy link
Contributor

remilapeyre commented Jun 14, 2020 •
edited by miss-islington

https://bugs.python.org/issue40967

Automerge-Triggered-By: @aeros

remilapeyre requested review from 1st1 and asvetlov as code owners Jun 14, 2020
aeros self-requested a review Jun 15, 2020
Copy link
Contributor Author

remilapeyre commented Jun 29, 2020

@aeros apparently we can go ahead with this according to the discussion on bpo. Let me know if this needs some changes.

Copy link
Member

aeros commented Jun 30, 2020

Yep! I should have some time to take a look tomorrow. Thanks for the PR.

aeros requested changes Jun 30, 2020
View changes
Copy link
Member

aeros left a comment

The following DeprecationWarning should also be removed:

cpython/Lib/test/test_asyncio/test_tasks.py

Lines 3002 to 3003 in 0968bb6

with self.assertWarns(DeprecationWarning):
self.assertEqual(asyncio.Task.all_tasks(loop), {task})

Also, the "What's New" 3.9 document should be updated, specifically the removals should be mentioned in the dedicated section, with a link to the asyncio.current_task() and asyncio.all_tasks() functions that can be used instead.

Other than that, it mostly looks good. I'll double check later to make sure the PR covers everything.

Copy link

bedevere-bot commented Jun 30, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Contributor

ambv commented Jun 30, 2020

I don't mean to scare you, especially given my late response on the issue, but this is blocking the release of 3.9.0b4. Please prioritize this :-)

Copy link
Contributor Author

remilapeyre commented Jun 30, 2020

Sorry, I will address the review in the next couple of hours

Copy link
Contributor Author

remilapeyre commented Jun 30, 2020

It should be good now, I fixed the C module that I had completely missed for some reason, updated the tests and added a note in What's New. Let me know if it needs anything else.

Copy link
Contributor Author

remilapeyre commented Jun 30, 2020

I have made the requested changes; please review again

Copy link

bedevere-bot commented Jun 30, 2020

Thanks for making the requested changes!

@aeros: please review the changes made to this pull request.

bedevere-bot requested a review from aeros Jun 30, 2020
aeros approved these changes Jul 2, 2020
View changes
Copy link
Member

aeros left a comment

Thanks for also taking care of removing the deprecated C-API part as well, I just recalled that we also needed to remove that earlier today. With the latest round of changes, it looks good to me.

I'll proceed with merging now since this is a release blocker for 3.9b4, but would greatly appreciate a post-commit review from @1st1 or @asvetlov to make sure we didn't miss anything.

aeros changed the title bpo-40967: Removed asyncio.Task.current_task() and asyncio.Task.all_tasks() bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.Task.all_tasks() Jul 2, 2020
aeros added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jul 2, 2020
miss-islington merged commit 004e64e into python:master Jul 2, 2020
4 checks passed
Copy link
Contributor

miss-islington commented Jul 2, 2020

Thanks @remilapeyre for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 2, 2020
bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.…
437a0ea 
…Task.all_tasks() (pythonGH-20874)

(cherry picked from commit 004e64e)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@lenstra.fr>
Copy link

bedevere-bot commented Jul 2, 2020

GH-21272 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jul 2, 2020
bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.…
df59293 
…Task.all_tasks() (GH-20874)

(cherry picked from commit 004e64e)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@lenstra.fr>
tirkarthi mentioned this pull request Jul 4, 2020
Closed
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
bpo-40967: Remove deprecated asyncio.Task.current_task() and asyncio.…
39f4980 
…Task.all_tasks() (pythonGH-20874)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

aeros

1st1

asvetlov

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants