[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-36807: When saving a file in IDLE, call flush and fsync (GH-13102) #13280

Closed
wants to merge 2 commits into from
Closed

[3.7] bpo-36807: When saving a file in IDLE, call flush and fsync (GH-13102) #13280

wants to merge 2 commits into from

Conversation

Copy link
Contributor

miss-islington commented May 13, 2019 •
edited by bedevere-bot
Loading

(cherry picked from commit 4f098b3)

Co-authored-by: Guido van Rossum guido@python.org

https://bugs.python.org/issue36807

bpo-36807: When saving a file in IDLE, call flush and fsync (pythonGH…
3629fed 
…-13102)

(cherry picked from commit 4f098b3)

Co-authored-by: Guido van Rossum <guido@python.org>
bedevere-bot mentioned this pull request May 13, 2019
Merged
bedevere-bot added the type-bug An unexpected behavior, bug, or error label May 13, 2019
Copy link
Contributor Author

@gvanrossum and @terryjreedy: Status check is done, and it's a failure ❌ .

1 similar comment
Copy link
Contributor Author

@gvanrossum and @terryjreedy: Status check is done, and it's a failure ❌ .

Copy link
Member

I suppose this needs to be merged manually? IIRC the Azure Pipelines test build is still flaky.

dhalbert suggested changes May 13, 2019
View reviewed changes
Misc/NEWS.d/next/IDLE/2019-05-05-16-27-53.bpo-13102.AGNWYJ.rst Outdated
@@ -0,0 +1 @@
When saving a file, call os.flush() so bits are flushed to e.g. USB drive.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typo, I think, should say call os.fsync().

Typo fix
fa0520a 
Fix typo in NEWS item about IDLE (os.flush() should be os.fsync())
miss-islington deleted the backport-4f098b3-3.7 branch May 13, 2019 16:06
Copy link
Member

Cannot merge when required test fails, even if irrelevant to patch. I forgot that that cannot close and reopen backport to rerun tests for backport. Will redo backport and correction.

terryjreedy mentioned this pull request May 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

dhalbert dhalbert requested changes

terryjreedy terryjreedy approved these changes

gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
awaiting merge type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants