[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

bpo-34652: Remove lchmod from the big func checking block. #9247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2018
Merged

bpo-34652: Remove lchmod from the big func checking block. #9247

merged 2 commits into from
Sep 13, 2018

Conversation

Copy link
Contributor

benjaminp commented Sep 12, 2018 •
edited by bedevere-bot
Loading

Arfrever reviewed Sep 12, 2018
View reviewed changes
pyconfig.h.in Outdated
@@ -557,9 +557,6 @@
/* Define to 1 if you have the 'lchflags' function. */
#undef HAVE_LCHFLAGS

/* Define to 1 if you have the `lchmod' function. */
#undef HAVE_LCHMOD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently AC_CHECK_FUNCS defines HAVE_* preprocessor macro when a function is found, but AC_CHECK_FUNC does not.
So AC_CHECK_FUNC(lchmod) should be changed to AC_CHECK_FUNCS(lchmod).
Then above deletion from pyconfig.h.in should disappear.

benjaminp merged commit ed709d5 into master Sep 13, 2018
Copy link
Contributor

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

benjaminp deleted the benjamin-lchmod-fix branch September 13, 2018 00:22
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2018
bpo-34652: Remove lchmod from the big func checking block. (pythonGH-…
23eb7df 
…9247)

A fix for 883702e.
(cherry picked from commit ed709d5)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
Copy link

GH-9249 is a backport of this pull request to the 3.7 branch.

Copy link
Contributor

Sorry, @benjaminp, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ed709d5699716bf7237856dc20aba321e2dfff6d 3.6

benjaminp added a commit that referenced this pull request Sep 13, 2018
[3.6] bpo-34652: Remove lchmod from the big func checking block. (GH-…
c84c4dc 
…9247)

A fix for 883702e..
(cherry picked from commit ed709d5)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
miss-islington added a commit that referenced this pull request Sep 13, 2018
bpo-34652: Remove lchmod from the big func checking block. (GH-9247)
35c94c7 
A fix for 883702e.
(cherry picked from commit ed709d5)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

Arfrever Arfrever left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

benjaminp

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants