[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33348: parse expressions after * and ** in lib2to3 #6586

Merged
merged 3 commits into from Oct 24, 2019

Conversation

Copy link
Contributor

zsol commented Apr 24, 2018

These are valid even in python 2.7

https://bugs.python.org/issue33348

Automerge-Triggered-By: @gpshead

Copy link
Contributor

thatch commented Jun 19, 2019

Ping for review... @pablogsal ?

Copy link

lybroman commented Jul 5, 2019

Any update on this issue?

gpshead self-assigned this Oct 24, 2019
Copy link
Member

gpshead commented Oct 24, 2019

closing and opening to re-trigger CI testing.

gpshead closed this Oct 24, 2019
gpshead reopened this Oct 24, 2019
Copy link
Contributor

miss-islington commented Oct 24, 2019

@zsol: Status check is done, and it's a success .

miss-islington merged commit 96b06ae into python:master Oct 24, 2019
Copy link
Contributor

miss-islington commented Oct 24, 2019

Thanks @zsol for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒🤖

Copy link

bedevere-bot commented Oct 24, 2019

GH-16913 is a backport of this pull request to the 3.8 branch.

Copy link

bedevere-bot commented Oct 24, 2019

GH-16914 is a backport of this pull request to the 3.7 branch.

Copy link
Contributor

miss-islington commented Oct 24, 2019

Sorry, @zsol, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 96b06aefe23521b61e4e9cdd44f5d30b00c7eb95 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2019
These are valid even in python 2.7

https://bugs.python.org/issue33348

Automerge-Triggered-By: @gpshead
(cherry picked from commit 96b06ae)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
Copy link
Member

gpshead commented Oct 24, 2019

If anyone wants to see this in lib2to3 included with the final 2.7.18 release of 2.7, they'l need to do the backport PR work. I suggest not worrying about it. :)

miss-islington added a commit that referenced this pull request Oct 24, 2019
These are valid even in python 2.7

https://bugs.python.org/issue33348

Automerge-Triggered-By: @gpshead
(cherry picked from commit 96b06ae)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
miss-islington added a commit that referenced this pull request Oct 24, 2019
These are valid even in python 2.7

https://bugs.python.org/issue33348

Automerge-Triggered-By: @gpshead
(cherry picked from commit 96b06ae)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants