bpo-32206: Update pdb usage to include new module option #5111

mariocj89 · 2018-01-06T10:35:21Z

Updates the usage to include the new option. Sorry @ncoghlan, I totally missed it in the previous PR

If you think it is not important/not worth it I am happy to just close it.

https://bugs.python.org/issue32206

ncoghlan · 2018-01-06T15:00:30Z

Good catch! There's a test case that checks the usage message is displayed as expected, so that will need to be updated appropriately (the purpose of that test is to check that pdb._usage is displayed as expected, rather than to check the contents of pdb._usage, so it would be reasonable to update the test case to re-use the module global and avoid the need to update it in two places).

ncoghlan · 2018-01-06T15:03:12Z

Lib/pdb.py


-Debug the Python program given by pyfile.
+Debug the Python program given by pyfile or the module specified.


I think this will be clearer as two sentences: "Debug the Python program given by pyfile. Alternatively, an executable module or package to debug can be specified using the -m switch."

the-knights-who-say-ni added the CLA signed label Jan 6, 2018

bedevere-bot added the awaiting review label Jan 6, 2018

ncoghlan added the skip news label Jan 6, 2018

ncoghlan reviewed Jan 6, 2018

View changes

mariocj89 force-pushed the update_pdb_usage branch from 173b533 to 8ee3a1c Compare Jan 6, 2018

Update pdb usage to include new module option

7661d96

mariocj89 force-pushed the update_pdb_usage branch from 8ee3a1c to 7661d96 Compare Jan 7, 2018

ncoghlan merged commit fcf8b4c into python:master Jan 28, 2018

bedevere-bot removed the awaiting review label Jan 28, 2018

mariocj89 deleted the update_pdb_usage branch Jan 29, 2018

bpo-32206: Update pdb usage to include new module option #5111

bpo-32206: Update pdb usage to include new module option #5111

mariocj89 commented Jan 6, 2018 •

edited

ncoghlan commented Jan 6, 2018

ncoghlan Jan 6, 2018


		Debug the Python program given by pyfile.
		Debug the Python program given by pyfile or the module specified.

bpo-32206: Update pdb usage to include new module option #5111

bpo-32206: Update pdb usage to include new module option #5111

Conversation

mariocj89 commented Jan 6, 2018 • edited

ncoghlan commented Jan 6, 2018

ncoghlan Jan 6, 2018

Choose a reason for hiding this comment

mariocj89 commented Jan 6, 2018 •

edited