[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bpo-30526: make TextIOWrapper.{line_buffering, write_through} writable #1887

Closed
wants to merge 1 commit into from
Closed

Fix bpo-30526: make TextIOWrapper.{line_buffering, write_through} writable #1887

wants to merge 1 commit into from

Conversation

Copy link
Member

pitrou commented May 31, 2017

This simplifies the reconfiguration of standard streams as it can now be done in-place.
Fix #30526: make TextIOWrapper.{line_buffering, write_through} writable
2fbc916 
This simplifies the reconfiguration of standard streams as it can now be done in-place.
pitrou requested a review from benjaminp May 31, 2017
Copy link

mention-bot commented May 31, 2017

@pitrou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @birkenfeld to be potential reviewers.
pitrou changed the title Fix #30526: make TextIOWrapper.{line_buffering, write_through} writable Fix bpo-30526: make TextIOWrapper.{line_buffering, write_through} writable May 31, 2017
Copy link
Member Author

pitrou commented May 31, 2017

The AppVeyor failure is unrelated.
benjaminp reviewed Jun 1, 2017
View changes
Copy link
Contributor

benjaminp left a comment

so what happens when I set line_buffering = True and write_through = True?
Doc/library/io.rst
@@ -908,6 +908,16 @@ Text I/O

Whether line buffering is enabled.

This comment has been minimized.

Sign in to view

benjaminp Jun 1, 2017
Contributor

should also say that writing to it flushes the stream
Doc/library/io.rst
.. attribute:: write_through

Whether writes are passed immediately to the underlying binary
buffer. This argument is writable.

This comment has been minimized.

Sign in to view

benjaminp Jun 1, 2017
Contributor

ditto
Copy link
Member Author

pitrou commented Jun 2, 2017

#1922 is now preferred.
Copy link
Member Author

pitrou commented Jun 2, 2017

so what happens when I set line_buffering = True and write_through = True?

Same as before: write_through takes precedence (everything is written through).
Copy link
Member Author

pitrou commented Jun 6, 2017

Superseded by #1922.
pitrou closed this Jun 6, 2017
pitrou deleted the pitrou:writable_line_buffering branch Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

benjaminp

Assignees
No one assigned
Labels
CLA signed type-enhancement
Projects
None yet
Milestone
No milestone
4 participants