[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags #21021

Merged
merged 4 commits into from Jun 28, 2020
Merged

bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags #21021

merged 4 commits into from Jun 28, 2020

Conversation

Copy link
Member

gvanrossum commented Jun 20, 2020 •
edited

Stefan Behnel reported that cf_feature_version is used even when
PyCF_ONLY_AST is not set. This is against the intention and against the
documented behavior, so it's been fixed. Includes a test contributed by Stefan.

https://bugs.python.org/issue35975

gvanrossum requested a review from pablogsal as a code owner Jun 20, 2020
Copy link
Member Author

gvanrossum commented Jun 21, 2020

I've done manual backports -- should I keep the "needs backport to XXX" labels or ditch them?

Copy link
Member

pablogsal commented Jun 21, 2020

I've done manual backports -- should I keep the "needs backport to XXX" labels or ditch them?

Let's remove them, because if not the bots will create PRs on merge

vstinner reviewed Jun 21, 2020
View changes
Misc/NEWS.d/next/Core and Builtins/2020-06-20-17-00-44.bpo-35975.UDHCHp.rst Outdated
@@ -0,0 +1,3 @@
Stefan Behnel reported that cf_feature_version is used even when
PyCF_ONLY_AST is not set. This is against the intention and against the
documented behavior, so I fixed it.
Copy link
Member

vstinner Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to avoid "I" in the NEWS entry? At least, replace it with Guido. Otherwise, it's unclear who is "I".

Copy link
Member Author

gvanrossum Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change this to "so it's been fixed."

Copy link
Member

vstinner Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

gvanrossum merged commit 9d197c7 into master Jun 28, 2020
10 checks passed
gvanrossum deleted the fix-cf-feature-version branch Jun 28, 2020
Copy link

bedevere-bot commented Jun 28, 2020

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

fasih pushed a commit to fasih/cpython that referenced this issue Jun 29, 2020
bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags (p…
0c61230 
…ython#21021)
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this issue Jul 21, 2020
bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags (p…
e95c19e 
…ython#21021)
chrisburr pushed a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags (p…
a768baf 
…ython#21021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

vstinner

pablogsal

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants