[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33169: Remove values of None from sys.path_importer_cache when invalidating caches #6402

Merged
merged 5 commits into from Apr 6, 2018
Merged

bpo-33169: Remove values of None from sys.path_importer_cache when invalidating caches #6402

merged 5 commits into from Apr 6, 2018

Conversation

Copy link
Member

brettcannon commented Apr 6, 2018 •
edited by bedevere-bot

An entry of None in sys.path_importer_cache represents a negative/missing finder for a path.

https://bugs.python.org/issue33169

brettcannon merged commit 9e2be60 into python:master Apr 6, 2018
Copy link
Contributor

miss-islington commented Apr 6, 2018

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

brettcannon deleted the invalidate-caches-None branch Apr 6, 2018
Copy link
Contributor

miss-islington commented Apr 6, 2018

Sorry, @brettcannon, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9e2be60634914f23db2ae5624e4acc9335bf5fea 3.7

brettcannon added a commit to brettcannon/cpython that referenced this pull request Apr 6, 2018
[3.7] bpo-33169: Remove values of None from sys.path_importer_cache…
ab9b245 
… when invalidating caches (pythonGH-6402)

An entry of None in sys.path_importer_cache represents a negative/missing finder for a path, so clearing it out makes sense..
(cherry picked from commit 9e2be60)

Co-authored-by: Brett Cannon <brettcannon@users.noreply.github.com>
Copy link

bedevere-bot commented Apr 6, 2018

GH-6403 is a backport of this pull request to the 3.7 branch.

brettcannon added a commit that referenced this pull request Apr 7, 2018
[3.7] bpo-33169: Remove values of None from sys.path_importer_cache…
a09bb87 
… when invalidating caches (GH-6402) (GH-6403)

An entry of None in sys.path_importer_cache represents a negative/missing finder for a path, so clearing it out makes sense.
(cherry picked from commit 9e2be60)
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
bpo-33169: Remove values of None from sys.path_importer_cache when …
2f038d0 
…invalidating caches (pythonGH-6402)

An entry of None in sys.path_importer_cache represents a negative/missing finder for a path, so clearing it out makes sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants