[proxy] web.archive.org← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35471: Remove the macpath module #11129

Merged
merged 2 commits into from Dec 14, 2018
Merged

Conversation

Copy link
Member

vstinner commented Dec 12, 2018

Python 2.4 dropped MacOS 9 support. The macpath module was deprecated
in Python 3.7. This change removes it.

https://bugs.python.org/issue35471

Python 2.4 dropped MacOS 9 support. The macpath module was deprecated
in Python 3.7. This change removes it.
Lib/posixpath.py Outdated Show resolved Hide resolved
</Project>
Copy link
Member

serhiy-storchaka Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change.

Copy link
Member Author

vstinner Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like my text editor (vim) likes to add newline. Well, this change shouldn't hurt :-)

@@ -124,7 +124,7 @@ def main():

# default the exclude list for each platform
if win: exclude = exclude + [
'dos', 'dospath', 'mac', 'macpath', 'macfs', 'MACFS', 'posix', ]
Copy link
Member

serhiy-storchaka Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'dospath'? Seriously? 😉

Copy link
Member Author

vstinner Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know any of these modules (except of "posix"), so I chose to not touch this old code...

Doc/library/os.path.rst Outdated Show resolved Hide resolved
serhiy-storchaka requested a review from a team Dec 12, 2018
Copy link
Member Author

vstinner commented Dec 12, 2018

@serhiy-storchaka: I made two changes, see my second commit.

Copy link
Member

ned-deily left a comment

LGTM, thanks

Copy link
Member Author

vstinner commented Dec 14, 2018

@ronaldoussoren wrote "I'm in favour of removing macpath.":
https://bugs.python.org/issue35471#msg331702

vstinner merged commit d7538dd into python:master Dec 14, 2018
vstinner deleted the remove_macpath branch Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants