[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20849: allow existing directory in shutil.copytree #2977

Closed
wants to merge 1 commit into from
Closed

bpo-20849: allow existing directory in shutil.copytree #2977

wants to merge 1 commit into from

Conversation

Copy link
Sponsor Contributor

ofek commented Aug 1, 2017 •
edited

This is a legacy thing that wasn't updated with https://docs.python.org/3/library/os.html#os.makedirs

https://bugs.python.org/issue20849

Let us not bikeshed this time!

ofek changed the title allow existing directory in shutil.copytree bpo-20849: allow existing directory in shutil.copytree Aug 1, 2017
Copy link

Should not we update the docstring too? Especially the The destination directory must not already exist. part.

Copy link
Member

make sense

Copy link

jnnnnn commented Mar 15, 2018

I need this!

Copy link
Member

@ofek Thanks for the PR and sorry that it has languished. But the PR cannot be accepted as is for two reasons: one, it ignores the discussion on the bug tracker about why changing the semantics of shutil.copytree to unconditionally ignore existing destination directories may be problematic; and two, we require PRs to be submitted against the cpython master branch, not a maintenance branch like 3.6; if a core developer decides to accept and merge a PR against master, they will decide whether any backports to maintenance branches are appropriate. Thus, I am closing the PR against 3.6. If you are still interested in pursuing this, perhaps making a new PR against master from the originally submitted patch might be a way forward.

https://devguide.python.org/#status-of-python-branches

ned-deily closed this Jun 7, 2018
ofek deleted the patch-1 branch June 7, 2018 04:37
jab mentioned this pull request Aug 16, 2018
Merged
Copy link
Contributor

jab commented Aug 16, 2018

Hi @ned-deily, I picked this back up in #8792 and addressed the outstanding concerns here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants