[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public

bpo-33710: Deprecate l*gettext() and related functions in the gettext module. #10139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 27, 2018
Merged

bpo-33710: Deprecate l*gettext() and related functions in the gettext module. #10139

merged 7 commits into from
Oct 27, 2018

Conversation

Copy link
Member

serhiy-storchaka commented Oct 26, 2018 •
edited by bedevere-bot
Loading

They return encoded bytes and are Python 2 artifacts.

https://bugs.python.org/issue33710

bpo-33710: Deprecate l*gettext() and related functions in the gettext…
53b2edf 
… module.

They return encoded bytes and are Python 2 artifacts.
serhiy-storchaka added the type-feature A feature request or enhancement label Oct 26, 2018
warsaw requested changes Oct 26, 2018
View reviewed changes
Copy link
Member

warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I have some wording suggestions, and one coding suggestion.

Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

warsaw and others added 6 commits October 26, 2018 21:55
Update Doc/whatsnew/3.8.rst
9521b19 
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Update Doc/whatsnew/3.8.rst
e96180e 
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Update Doc/whatsnew/3.8.rst
319c4d5 
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Update Doc/whatsnew/3.8.rst
18a83d7 
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Update Misc/NEWS.d/next/Library/2018-10-26-21-12-55.bpo-33710.Q5oXc6.rst
0ed09ef 
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
Update 3.8.rst
c93dd56
Copy link
Member Author

Thank you Barry! I have made the requested changes; please review again.

Copy link

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

serhiy-storchaka merged commit fec35c9 into python:master Oct 27, 2018
serhiy-storchaka deleted the deprecate-lgettext branch October 27, 2018 05:00
tirkarthi mentioned this pull request Aug 24, 2021
Closed
donBarbos added a commit to donBarbos/typeshed that referenced this pull request Aug 6, 2025
[gettext] Deprecate l*gettext() functions and related
daeb92b 
Source: python/cpython#10139
donBarbos mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

warsaw warsaw approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants