[proxy] web.archive.org — ← back | site home | direct (HTTPS) ↗ | proxy home | ◑ dark◐ light
/ cpython Public
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32102 Doc: add missing capture_output arg to subprocess.run() signature #8374

Merged
merged 1 commit into from Aug 9, 2018
Merged

bpo-32102 Doc: add missing capture_output arg to subprocess.run() signature #8374

merged 1 commit into from Aug 9, 2018

Conversation

Copy link
Contributor

and800 commented Jul 21, 2018 •
edited by bedevere-bot

trivial doc fix, needs backport to 3.7

https://bugs.python.org/issue32102

and800 requested a review from gpshead as a code owner Jul 21, 2018
bedevere-bot added the docs Documentation in the Doc dir label Jul 21, 2018
Copy link
Contributor Author

and800 commented Aug 6, 2018

@gpshead could you help me with this one?

Copy link
Sponsor Member

Mariatta commented Aug 9, 2018 •
edited by bedevere-bot

News not needed but I think we can re-use bpo-32102 as issue number, where this was added.

Mariatta changed the title Doc: add missing capture_output arg to subprocess.run() signature bpo-32102 Doc: add missing capture_output arg to subprocess.run() signature Aug 9, 2018
gpshead merged commit 22d131a into python:master Aug 9, 2018
9 checks passed
Copy link

bedevere-bot commented Aug 9, 2018

@gpshead: Please replace # with GH- in the commit message next time. Thanks!

Copy link
Contributor

miss-islington commented Aug 9, 2018

Thanks @and800 for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Copy link

bedevere-bot commented Aug 9, 2018

GH-8720 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 9, 2018
Doc: add missing capture_output arg to subprocess.run() signature (py…
0b7bab1 
…thonGH-8374)

(cherry picked from commit 22d131a)

Co-authored-by: Andriy Maletsky <9919211+and800@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Aug 9, 2018
Doc: add missing capture_output arg to subprocess.run() signature (GH…
5641081 
…-8374)

(cherry picked from commit 22d131a)

Co-authored-by: Andriy Maletsky <9919211+and800@users.noreply.github.com>
yahya-abou-imran pushed a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018
Doc: add missing capture_output arg to subprocess.run() signature (py…
a111b50 
…thon#8374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Mariatta

gpshead

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants