bpo-38778: Document that os.fork is not allowed in subinterpreters #17123

phmc · 2019-11-12T14:44:16Z

Small docs update for bpo-34651.

Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed.

https://bugs.python.org/issue38778

Automerge-Triggered-By: @ericsnowcurrently

the-knights-who-say-ni · 2019-11-12T14:44:20Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@phmc

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

gpshead · 2019-11-12T19:51:26Z

Could you add a versionchanged marker in the docs for this?

brandtbucher · 2019-11-12T20:13:12Z

Thanks for your time @phmc, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

brandtbucher

I have a couple of minor suggestions, but otherwise this looks good:

Doc/library/os.rst

Misc/NEWS.d/next/Documentation/2019-11-12-15-31-09.bpo-38778.PHhTlv.rst

…HhTlv.rst Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

phmc · 2019-11-13T10:05:24Z

Thanks guys. Just needed to associate my github account with my bpo account (I've not contributed anything since the hg days :))

I've changed the note to a versionchanged (didn't seem helpful to keep both) and incorporated Brandt's suggestions.

brandtbucher · 2019-11-13T19:46:06Z

Thanks @phmc!

The Travis failure looks like an issue on their end, unrelated to your changes. Pushing to your branch or closing-and-reopening this PR (not making a new one) should re-trigger the build.

brandtbucher

Looks good!

phmc · 2019-11-14T09:02:38Z

Gave travis a kick as suggested by Brandt, looks like everything has come back clean now.

ericsnowcurrently

LGTM

FYI, I basically copied-and-pasted your text for the forkpty() doc entry.

Also, there are some related changed to be made to the C-API docs, but I'll do that separately.

miss-islington · 2019-11-15T16:56:02Z

@phmc: Status check is done, and it's a success ✅ .

miss-islington · 2019-11-15T16:56:07Z

Thanks @phmc for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington · 2019-11-15T16:56:08Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

brandtbucher · 2019-11-15T17:12:03Z

Congrats on your first CPython contribution @phmc! 🍾

Looking forward to seeing more from you in the future.

miss-islington · 2019-11-15T18:11:54Z

Thanks @phmc for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington · 2019-11-15T18:11:55Z

Sorry @phmc, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b22030073b9327a3aeccb69507694bce078192aa 3.8

miss-islington · 2019-11-15T21:30:39Z

Thanks @phmc for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@ericsnowcurrently

…ythonGH-17123) Small docs update for [bpo-34651](https://bugs.python.org/issue34651). Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed. https://bugs.python.org/issue38778 Automerge-Triggered-By: @ericsnowcurrently (cherry picked from commit b220300) Co-authored-by: Phil Connell <pconnell@gmail.com>

bedevere-bot · 2019-11-15T21:30:48Z

GH-17179 is a backport of this pull request to the 3.8 branch.

@ericsnowcurrently

…H-17123) Small docs update for [bpo-34651](https://bugs.python.org/issue34651). Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed. https://bugs.python.org/issue38778 Automerge-Triggered-By: @ericsnowcurrently (cherry picked from commit b220300) Co-authored-by: Phil Connell <pconnell@gmail.com>

@ericsnowcurrently

…ythonGH-17123) Small docs update for [bpo-34651](https://bugs.python.org/issue34651). Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed. https://bugs.python.org/issue38778 Automerge-Triggered-By: @ericsnowcurrently

@ericsnowcurrently

…ythonGH-17123) Small docs update for [bpo-34651](https://bugs.python.org/issue34651). Other references to fork (e.g. the PyOS.*Fork functions or discussions of fork() when embedding Python) point back to os.fork, so I don't think any other updates are needed. https://bugs.python.org/issue38778 Automerge-Triggered-By: @ericsnowcurrently

bpo-38778: Document that os.fork is not allowed in subinterpreters

6a29db5

the-knights-who-say-ni added the CLA not signed label Nov 12, 2019

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 12, 2019

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Nov 12, 2019

📜🤖 Added by blurb_it.

6a1df36

brandtbucher approved these changes Nov 12, 2019

View reviewed changes

Doc/library/os.rst Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Documentation/2019-11-12-15-31-09.bpo-38778.PHhTlv.rst Outdated Show resolved Hide resolved

bedevere-bot added awaiting core review and removed awaiting review labels Nov 12, 2019

phmc and others added 3 commits November 13, 2019 09:56

Update Misc/NEWS.d/next/Documentation/2019-11-12-15-31-09.bpo-38778.P…

7f22c35

…HhTlv.rst Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

bpo-38778: PR markups -- add a versionchanged note in the docs

7b7a63c

bpo-38778: PR markups -- minor formatting changes

827295e

brandtbucher approved these changes Nov 13, 2019

View reviewed changes

phmc closed this Nov 14, 2019

phmc reopened this Nov 14, 2019

Add the same note for forkpty().

ea9b70c

ericsnowcurrently approved these changes Nov 15, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Nov 15, 2019

ericsnowcurrently added needs backport to 3.8 labels Nov 15, 2019

miss-islington merged commit b220300 into python:master Nov 15, 2019

bedevere-bot removed the awaiting merge label Nov 15, 2019

ericsnowcurrently added needs backport to 3.8 and removed needs backport to 3.8 labels Nov 15, 2019

miss-islington self-assigned this Nov 15, 2019

ericsnowcurrently added needs backport to 3.8 and removed needs backport to 3.8 labels Nov 15, 2019

bedevere-bot removed the needs backport to 3.8 label Nov 15, 2019

Uh oh!

bpo-38778: Document that os.fork is not allowed in subinterpreters #17123

bpo-38778: Document that os.fork is not allowed in subinterpreters #17123

Uh oh!

Conversation

phmc commented Nov 12, 2019 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Nov 12, 2019

Recognized GitHub username

Uh oh!

gpshead commented Nov 12, 2019

Uh oh!

brandtbucher commented Nov 12, 2019

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

phmc commented Nov 13, 2019

Uh oh!

brandtbucher commented Nov 13, 2019

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

phmc commented Nov 14, 2019

Uh oh!

ericsnowcurrently left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Nov 15, 2019

Uh oh!

miss-islington commented Nov 15, 2019

Uh oh!

miss-islington commented Nov 15, 2019

Uh oh!

brandtbucher commented Nov 15, 2019

Uh oh!

miss-islington commented Nov 15, 2019

Uh oh!

miss-islington commented Nov 15, 2019

Uh oh!

miss-islington commented Nov 15, 2019

Uh oh!

bedevere-bot commented Nov 15, 2019

Uh oh!

Uh oh!

phmc commented Nov 12, 2019 •

edited by miss-islington

Loading