Issue16285
Created on 2012-10-19 10:56 by Matteo.Parrucci, last changed 2017-03-31 16:36 by dstufft. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 0be3805cade1.diff | ctheune, 2014-04-17 16:47 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 173 | merged | python-dev, 2017-02-19 08:55 | |
| PR 552 | closed | dstufft, 2017-03-31 16:36 | |
| Repositories containing patches | |||
|---|---|---|---|
| https://bitbucket.org/ctheune/cpython#default-16285 | |||
| Messages (6) | |||
|---|---|---|---|
| msg173319 - (view) | Author: Matteo Parrucci (Matteo.Parrucci) | Date: 2012-10-19 10:56 | |
RFC 3986 (http://www.ietf.org/rfc/rfc3986.txt) says: For consistency, percent-encoded octets in the ranges of ALPHA (%41-%5A and %61-%7A), DIGIT (%30-%39), hyphen (%2D), period (%2E), underscore (%5F), or tilde (%7E) should not be created by URI producers and, when found in a URI, should be decoded to their corresponding unreserved characters by URI normalizers. From python documentation talking about urllib.quote() Example: quote('/~connolly/') yields '/%7econnolly/'. I think ~ should be added to the safe characters of quote function |
|||
| msg173327 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * | Date: 2012-10-19 11:43 | |
Yes, urllib based on RFC 2396, but RFC 3986 obsoletes RFC 2396. Updating to RFC 3986 should be new feature. For older versions can not change anything. But you always can use "safe" argument with quote(). |
|||
| msg216698 - (view) | Author: Christian Theune (ctheune) * | Date: 2014-04-17 15:46 | |
I'll update this. |
|||
| msg288086 - (view) | Author: Ratnadeep Debnath (rtnpro) * | Date: 2017-02-18 19:37 | |
I have started to work on this issue and get it merge ready. |
|||
| msg288122 - (view) | Author: Ratnadeep Debnath (rtnpro) * | Date: 2017-02-19 08:58 | |
Created a pull request for the attached patch along with update of related docstrings. |
|||
| msg290403 - (view) | Author: Nick Coghlan (ncoghlan) * | Date: 2017-03-24 23:46 | |
New changeset 21024f06622c4c55b666adb130797a4ee205d005 by Nick Coghlan (Ratnadeep Debnath) in branch 'master': bpo-16285: Update urllib quoting to RFC 3986 (#173) https://github.com/python/cpython/commit/21024f06622c4c55b666adb130797a4ee205d005 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2017-03-31 16:36:10 | dstufft | set | pull_requests: + pull_request863 |
| 2017-03-24 23:46:26 | ncoghlan | set | messages: + msg290403 |
| 2017-02-25 09:00:58 | ncoghlan | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2017-02-25 08:23:56 | ncoghlan | set | assignee: ncoghlan |
| 2017-02-25 08:23:45 | ncoghlan | set | stage: needs patch -> patch review |
| 2017-02-19 08:58:02 | rtnpro | set | messages: + msg288122 |
| 2017-02-19 08:55:11 | python-dev | set | pull_requests: + pull_request139 |
| 2017-02-19 06:43:00 | ncoghlan | set | versions: + Python 3.7, - Python 3.5 |
| 2017-02-18 19:37:00 | rtnpro | set | nosy:
+ rtnpro messages: + msg288086 |
| 2017-01-20 16:46:30 | piotr.dobrogost | set | nosy:
+ piotr.dobrogost |
| 2014-04-18 01:50:23 | martin.panter | set | nosy:
+ martin.panter |
| 2014-04-17 16:47:08 | ctheune | set | versions: + Python 3.5, - Python 3.4 |
| 2014-04-17 16:47:03 | ctheune | set | files:
+ 0be3805cade1.diff keywords: + patch |
| 2014-04-17 16:46:47 | ctheune | set | hgrepos: - hgrepo242 |
| 2014-04-17 16:46:38 | ctheune | set | hgrepos: + hgrepo242 |
| 2014-04-17 16:04:16 | ctheune | set | hgrepos: + hgrepo241 |
| 2014-04-17 15:58:44 | ctheune | set | title: Update urllib to RFC 3986 -> Update urllib quoting to RFC 3986 |
| 2014-04-17 15:55:52 | pitrou | set | nosy:
+ ncoghlan |
| 2014-04-17 15:46:43 | ctheune | set | nosy:
+ ctheune messages: + msg216698 |
| 2012-11-12 08:41:53 | serhiy.storchaka | set | stage: needs patch |
| 2012-10-26 07:06:56 | cvrebert | set | nosy:
+ cvrebert |
| 2012-10-25 17:28:33 | ezio.melotti | set | nosy:
+ ezio.melotti |
| 2012-10-19 11:43:08 | serhiy.storchaka | set | type: enhancement title: Erroneously encoding tilde to %7e in quote -> Update urllib to RFC 3986 components: + Library (Lib) nosy:
+ serhiy.storchaka, orsenthil |
| 2012-10-19 10:56:08 | Matteo.Parrucci | create | |