Issue 17923: test glob with trailing slash fail on AIX 6.1

test_glob's trailing_slash tests fails on AIX 6.1/Python 2.7.4:

The code section for no_magic/slash case seems to be the issue.

Attached patch resolves issue.

FAIL: test_glob_directory_with_trailing_slash (test.test_glob.GlobTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/freeware/lib/python2.7/test/test_glob.py", line 120, in test_glob_directory_with_trailing_slash
    self.assertEqual(res, [])
AssertionError: Lists differ: ['@test_7602318_tmp_dir/ZZZ/'] != []

First list contains 1 additional elements.
First extra element 0:
@test_7602318_tmp_dir/ZZZ/

- ['@test_7602318_tmp_dir/ZZZ/']
+ []

======================================================================
FAIL: test_glob_unicode_directory_with_trailing_slash (test.test_glob.GlobTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/freeware/lib/python2.7/test/test_glob.py", line 137, in test_glob_unicode_directory_with_trailing_slash
    self.assertEqual(res, [])
AssertionError: Lists differ: [u'@test_7602318_tmp_dir/ZZZ/'... != []

First list contains 1 additional elements.
First extra element 0:
@test_7602318_tmp_dir/ZZZ/

- [u'@test_7602318_tmp_dir/ZZZ/']
+ []

Couldn't part of the patch be simplified to:-

if basename or os.path.isdir(dirname):
    yield pathname

or have I misread it?

Someone on AIX should verify this patch and confirm that it fixes the issue (and if Python 3 is affected or not).

I tried the patch with Python-2.7.8 and it fixes the test_glob failure.  Thanks!

The failure also occurs with Python 3 and the patch fixes test_glob for those releases.

David, reproducible on 3.4 and default? 

We can use Version to reflect where changes need to be committed

3.4 and default also. The failure occurs on all branches and default.

New changeset e430973149ed by Serhiy Storchaka in branch '2.7':
Issue #17923: glob() patterns ending with a slash no longer match non-dirs on
http://hg.python.org/cpython/rev/e430973149ed

New changeset 5033589a752d by Serhiy Storchaka in branch '3.4':
Issue #17923: glob() patterns ending with a slash no longer match non-dirs on
http://hg.python.org/cpython/rev/5033589a752d

New changeset 6a71d3c79653 by Serhiy Storchaka in branch 'default':
Issue #17923: glob() patterns ending with a slash no longer match non-dirs on
http://hg.python.org/cpython/rev/6a71d3c79653

Thank you Delhallt.

Mark, yes, you are right, but the code can be simplified even more, to do less syscalls.

stage: commit review -> resolved

nosy: + serhiy.storchaka
stage: patch review -> commit review

messages: + msg224784
title: test glob with trailing slash fail -> test glob with trailing slash fail on AIX 6.1

components: + Library (Lib)
stage: patch review