Issue 20627: Add context manager support to xmlrpc.client.ServerProxy

Otherwise have to call client('close')() to close a server proxy and that's just ugly.

Hi. Here's a simple patch for this.

Thanks for the patch, Cladiu! Since the 3.5 branch is not open yet it might not be until late March or April when I can look at this patch and get it committed, but I will get to it.

Thanks for the patch, Claudiu.Popa! I noticed one tiny thing, which is that it introduced some trailing whitespace. I've uploaded a trivial change to your patch that removes the whitespace.

* The patch applies cleanly.
* The docs build cleanly with the patch.
* test_xmlrpc passes with the patch.
* I visually inspected the changes in the built HTML docs and they look good. I also ran the modified example code from the docs and confirmed that it runs as expected.

=> needs review

Cool, thanks, Jessica!

Looks good to me; left some comments on Rietveld.

Thanks for the review, Éric! I uploaded a new version of the patch, which addresses your comments.

Patch updated with fixes suggested by Éric.

This looks ready to me.  Thanks Claudiu!

My pleasure. Thanks for the reviews, too!

Now that the 3.5 branch is the default, can this feature be committed?

Yes it can. I do my Python work typically on Fridays so I will get to it then.

New changeset 395904f70d6a by Brett Cannon in branch 'default':
Issue #20627: xmlrpc.client.ServerProxy is now a context manager.
http://hg.python.org/cpython/rev/395904f70d6a

Thanks for the patch!

My pleasure!

messages: + msg213285
stage: patch review -> commit review

messages: + msg213279

nosy: + jesstess
messages: + msg212981

keywords: + needs review, - patch, easy
stage: needs patch -> patch review

nosy: + Claudiu.Popa
messages: + msg211359

keywords: + patch

stage: test needed -> needs patch