Issue 21222: Mock create_autospec with name argument fails

>>> from unittest import mock
>>> def b():
...   print("hello")
... 
>>> q = mock.create_autospec(b, name="a")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/kdas/code/python/cpython3/Lib/unittest/mock.py", line 2092, in create_autospec
    name=_name, **_kwargs)
TypeError: type object got multiple values for keyword argument 'name'

The issue was originally reported on mock bug tracker. I am working on a patch for the same.

Fix for the issue with test case. We are checking name in keyword arguments, if found replace _name with it and delete it from keyword arguments.

You can use kwargs.pop instead of the two step fetch and delete. 

For the test, could you add an assert that the name is used. Can you add an extra underscore to the method name, to make it: test_create_autospec_with_name

New patchset with changes made as suggested.

Looks good to me, but please change qobj and add a NEWS entry.

New changeset d471b0d38516 by Kushal Das in branch '3.4':
Closes Issue 21222.
http://hg.python.org/cpython/rev/d471b0d38516

New changeset 941117aaa32bf8b02c739ad848ac727292f75b05 by Steve Dower in branch '3.9':
bpo-21222: Fix improperly merged change so that final hooks are called before types are cleared (GH-21304)
https://github.com/python/cpython/commit/941117aaa32bf8b02c739ad848ac727292f75b05

pull_requests: + pull_request20455

pull_requests: + pull_request20453

nosy: + python-dev
messages: + msg216371

resolution: fixed
stage: resolved

messages: + msg216343