Issue 21722: teach distutils "upload" to exit with code != 0 when error occurs

This patch teaches distutils/command/upload.py to return a non-zero exit code when uploading fails.  Currently a zero error code is returned (specifically, no Exception is raised by upload.run(...)) regardless of the HTTP response from the server or any socket error during that conversation.

Should be applied against tip.

Thanks.

The attached file is a patch for backporting this fix to 2.7.7.

Thanks you for the patch. It may be good to add a unit test for this.
Also, for development, it is probably better to use a Mercurial clone instead of trying to generate diffs by hand. See the devguide for more information: https://docs.python.org/devguide/

Here is the patch against hg tip.

Here is the patch against hg 2.7.

I will submit patches with tests as soon as the before & after tests finish.

Here is the patch against tip, including a new test case.

Here is the patch against 2.7, including a new test case.

If you'd like me to change anything about the test case please let me know.

I've got the contrib form bit now.

Thank you Martin. I will take a look soon at the patch.

New changeset d86214c98a9c by Antoine Pitrou in branch '3.4':
Issue #21722: The distutils "upload" command now exits with a non-zero return code when uploading fails.
http://hg.python.org/cpython/rev/d86214c98a9c

New changeset 979aaa08c067 by Antoine Pitrou in branch 'default':
Issue #21722: The distutils "upload" command now exits with a non-zero return code when uploading fails.
http://hg.python.org/cpython/rev/979aaa08c067

New changeset cf70f030a744 by Antoine Pitrou in branch '2.7':
Issue #21722: The distutils "upload" command now exits with a non-zero return code when uploading fails.
http://hg.python.org/cpython/rev/cf70f030a744

I've now committed the fix. Thank you for your contribution!

resolution: fixed
stage: resolved

messages: + msg220324

messages: + msg220323

messages: + msg220321

messages: + msg220320

messages: + msg220277