Issue23451
Created on 2015-02-11 23:34 by BreamoreBoy, last changed 2019-08-02 22:25 by steve.dower. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| Deprecations.txt | BreamoreBoy, 2015-02-11 23:34 | |||
| 23451_1.patch | steve.dower, 2015-02-12 02:17 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 2318 | merged | Segev Finer, 2017-06-21 21:58 | |
| PR 11190 | merged | vstinner, 2018-12-17 10:48 | |
| PR 11191 | merged | miss-islington, 2018-12-17 11:12 | |
| Messages (12) | |||
|---|---|---|---|
| msg235778 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2015-02-11 23:34 | |
Raised as a placeholder. |
|||
| msg235781 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2015-02-11 23:40 | |
Using Microsoft Visual Studio Express 2013 for Windows Desktop. |
|||
| msg235786 - (view) | Author: Steve Dower (steve.dower) * | Date: 2015-02-12 01:24 | |
Adding 'socket' nosy list, as Antoine may have a stronger opinion about changing _socket to avoid these warnings - they aren't all in Windows-exclusive code. Or I'm happy to add the suppression to the build if that's the better option. I'll work up a patch for the GetVersion deprecations. I believe they're mostly checking for Vista, which we can assume now, so they aren't necessary. |
|||
| msg235789 - (view) | Author: Steve Dower (steve.dower) * | Date: 2015-02-12 02:17 | |
Patch attached. Interesting, once you declare Vista as the minimum API set, WinSock claims to support CMSG_LEN which enables sendmsg() et al support in _socket. Since the WinSock API bears little relation to the POSIX(?) API, it doesn't build, so I've just undef'd CMSG_LEN when building socket. |
|||
| msg236645 - (view) | Author: Steve Dower (steve.dower) * | Date: 2015-02-26 05:01 | |
Anyone got a chance to double-check my patch for me? I think it's fine, unless someone really wants me to turn all the "#ifdef CMSG_LEN" checks into "#ifdef HAVE_CMSG" (which I *think* would require autoconf updates, which I am totally unqualified to do...) |
|||
| msg237055 - (view) | Author: Roundup Robot (python-dev) | Date: 2015-03-02 16:01 | |
New changeset 57e2549cc9a6 by Steve Dower in branch 'default': Issue #23451: Update pyconfig.h for Windows to require Vista headers and remove unnecessary version checks. https://hg.python.org/cpython/rev/57e2549cc9a6 |
|||
| msg237056 - (view) | Author: Steve Dower (steve.dower) * | Date: 2015-03-02 16:03 | |
The _WINSOCK_DEPRECATED_NO_WARNINGS question is still open, but the rest of the deprecations should be clear now. |
|||
| msg239401 - (view) | Author: Roundup Robot (python-dev) | Date: 2015-03-27 13:29 | |
New changeset f64d0b99d405 by Victor Stinner in branch 'default': Issue #23451, #22117: Python 3.5 now requires Windows Vista or newer, so https://hg.python.org/cpython/rev/f64d0b99d405 |
|||
| msg297224 - (view) | Author: Steve Dower (steve.dower) * | Date: 2017-06-28 20:51 | |
New changeset 9f3bdcb643623e07497af2fc35f0496c2302f1be by Steve Dower (Segev Finer) in branch 'master': bpo-23451: Fix socket deprecation warnings in socketmodule.c (#2318) https://github.com/python/cpython/commit/9f3bdcb643623e07497af2fc35f0496c2302f1be |
|||
| msg297231 - (view) | Author: Steve Dower (steve.dower) * | Date: 2017-06-28 21:20 | |
There is only one deprecation warning left in current builds: ..\Modules\expat\xmlparse.c(796): warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. |
|||
| msg331982 - (view) | Author: STINNER Victor (vstinner) * | Date: 2018-12-17 11:12 | |
New changeset 3ab064e80a9be1e6e9c62437fffb92bde9c5e1fb by Victor Stinner in branch 'master': bpo-23451: Update time.monotonic() documentation (GH-11190) https://github.com/python/cpython/commit/3ab064e80a9be1e6e9c62437fffb92bde9c5e1fb |
|||
| msg331989 - (view) | Author: miss-islington (miss-islington) | Date: 2018-12-17 11:31 | |
New changeset c367d52a74781b2c9ffd9e29722fbdfc0234408c by Miss Islington (bot) in branch '3.7': bpo-23451: Update time.monotonic() documentation (GH-11190) https://github.com/python/cpython/commit/c367d52a74781b2c9ffd9e29722fbdfc0234408c |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-08-02 22:25:29 | steve.dower | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2018-12-17 11:31:05 | miss-islington | set | nosy:
+ miss-islington messages: + msg331989 |
| 2018-12-17 11:12:54 | miss-islington | set | pull_requests: + pull_request10430 |
| 2018-12-17 11:12:36 | vstinner | set | nosy:
+ vstinner messages: + msg331982 |
| 2018-12-17 10:48:04 | vstinner | set | stage: patch review pull_requests: + pull_request10428 |
| 2017-06-28 21:20:09 | steve.dower | set | messages:
+ msg297231 versions: + Python 3.7, - Python 3.5 |
| 2017-06-28 20:51:02 | steve.dower | set | messages: + msg297224 |
| 2017-06-25 04:26:39 | zach.ware | link | issue27523 superseder |
| 2017-06-21 22:31:20 | BreamoreBoy | set | nosy:
- BreamoreBoy |
| 2017-06-21 21:58:31 | Segev Finer | set | pull_requests: + pull_request2368 |
| 2015-03-27 13:29:47 | python-dev | set | messages: + msg239401 |
| 2015-03-02 16:03:13 | steve.dower | set | messages: + msg237056 |
| 2015-03-02 16:01:50 | python-dev | set | nosy:
+ python-dev messages: + msg237055 |
| 2015-02-26 05:01:46 | steve.dower | set | messages: + msg236645 |
| 2015-02-12 02:17:08 | steve.dower | set | files:
+ 23451_1.patch keywords: + patch messages: + msg235789 |
| 2015-02-12 01:24:13 | steve.dower | set | nosy:
+ pitrou messages: + msg235786 |
| 2015-02-11 23:41:00 | BreamoreBoy | set | messages: + msg235781 |
| 2015-02-11 23:34:06 | BreamoreBoy | create | |